Skip to content

feat(TCK): NodeCreate endpoint and bug fixes - #1486

Merged
0xivanov merged 5 commits into
mainfrom
feat-tck-node-create-endpoint
Sep 15, 2025
Merged

feat(TCK): NodeCreate endpoint and bug fixes#1486
0xivanov merged 5 commits into
mainfrom
feat-tck-node-create-endpoint

Conversation

@0xivanov

@0xivanov 0xivanov commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Description:

  • Implements node create endpoint
  • Makes freeze error check take place after freeze method
  • Fixes some status codes numbers

Related issue(s):

Fixes #1487

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Sep 11, 2025
@lfdt-bot

lfdt-bot commented Sep 11, 2025

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codecov

codecov Bot commented Sep 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
sdk/endpoint.go 100.00% <100.00%> (+40.90%) ⬆️
sdk/errors.go 64.51% <ø> (ø)
sdk/node_create_transaction.go 94.11% <100.00%> (+5.67%) ⬆️
sdk/status.go 99.86% <100.00%> (ø)
sdk/transaction.go 69.33% <100.00%> (+0.11%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Comment thread sdk/transaction.go Outdated
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
0xivanov marked this pull request as ready for review September 11, 2025 12:10
@0xivanov
0xivanov requested review from a team as code owners September 11, 2025 12:10
@0xivanov
0xivanov requested a review from gsstoykov September 11, 2025 12:10
Comment thread sdk/node_create_transaction.go Outdated
Comment thread sdk/transaction.go Outdated
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
0xivanov merged commit 5d6e1ec into main Sep 15, 2025
13 checks passed
@0xivanov
0xivanov deleted the feat-tck-node-create-endpoint branch September 15, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TCK: NodeCreate endpoint

3 participants