Skip to content

feat(TCK): NodeUpdate and NodeDelete methods - #1490

Merged
0xivanov merged 9 commits into
mainfrom
feat-tck-node-update-and-delete-method
Sep 15, 2025
Merged

feat(TCK): NodeUpdate and NodeDelete methods#1490
0xivanov merged 9 commits into
mainfrom
feat-tck-node-update-and-delete-method

Conversation

@0xivanov

@0xivanov 0xivanov commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

  • Implementes NodeUpdate and NodeDelete TCK methods
  • Adds validation to NodeUpdate to align with JS SDK

Related issue(s):

Fixes #1494 #1495

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov
feat: node create endpoint and fix bugs
2998358 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: add unit tests
6772a77 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: revert freeze changes
2a3d5ce 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: refactor
978bcc1 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
feat: node update and delete methods
bc14c18 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Sep 12, 2025
@lfdt-bot

lfdt-bot commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

Base automatically changed from feat-tck-node-create-endpoint to main September 15, 2025 10:42
@0xivanov
chore: merge from main
ffa384d 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: fix tests
a1da862 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
0xivanov marked this pull request as ready for review September 15, 2025 11:37
@0xivanov
0xivanov requested review from a team as code owners September 15, 2025 11:37
@0xivanov
0xivanov requested a review from SimiHunjan September 15, 2025 11:37
@0xivanov
chore: fix tests
2262a62 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@codecov

codecov Bot commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/node_update_transaction.go 30.76% 12 Missing and 6 partials ⚠️
Files with missing lines Coverage Δ
sdk/node_create_transaction.go 94.02% <100.00%> (-0.09%) ⬇️
sdk/node_delete_transaction.go 92.18% <100.00%> (+0.38%) ⬆️
sdk/node_update_transaction.go 75.52% <30.76%> (-5.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xivanov
chore: clean up
f3e83e6 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
gsstoykov approved these changes Sep 15, 2025
View reviewed changes

@gsstoykov gsstoykov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov
0xivanov merged commit d4c13a5 into main Sep 15, 2025
16 of 19 checks passed
@0xivanov
0xivanov deleted the feat-tck-node-update-and-delete-method branch September 15, 2025 13:52
@0xivanov 0xivanov mentioned this pull request Sep 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes
@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan is a code owner automatically assigned from hiero-ledger/hiero-sdk-go-maintainers

Assignees

@0xivanov 0xivanov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TCK: NodeUpdate endpoint

3 participants

@0xivanov @lfdt-bot @gsstoykov