Skip to content

fix: Static utility transaction methods for chunked transactions - #1505

Merged
0xivanov merged 1 commit into
mainfrom
1472-transaction-sign-does-not-work-for-generic-methods
Sep 26, 2025
Merged

fix: Static utility transaction methods for chunked transactions#1505
0xivanov merged 1 commit into
mainfrom
1472-transaction-sign-does-not-work-for-generic-methods

Conversation

@0xivanov

Copy link
Copy Markdown
Contributor

Description:

  • Fixes TransactionSign and TransactionExecute to work with chunked transactions by calling the overridden implementations.

Related issue(s):

Fixes #1472

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Sep 24, 2025
@0xivanov
0xivanov requested a review from a team as a code owner September 24, 2025 12:18
@0xivanov 0xivanov added the bug Something isn't working label Sep 24, 2025
@0xivanov
0xivanov requested a review from a team as a code owner September 24, 2025 12:18
@0xivanov
0xivanov requested a review from gsstoykov September 24, 2025 12:18
@lfdt-bot

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codecov

codecov Bot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
sdk/transaction.go 70.26% <100.00%> (+0.93%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsstoykov gsstoykov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov
0xivanov merged commit 36d8a29 into main Sep 26, 2025
18 of 19 checks passed
@0xivanov
0xivanov deleted the 1472-transaction-sign-does-not-work-for-generic-methods branch September 26, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic TransactionSign does not work on chunked transactions

3 participants