test: Add LiveHash unit tests - #1719
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Dosik13
reviewed
May 19, 2026
Dosik13
reviewed
May 19, 2026
Mounil2005
force-pushed
the
add-livehash-unit-tests
branch
from
May 21, 2026 21:42
31d8dfb to
3ee4f2d
Compare
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
Mounil2005
force-pushed
the
add-livehash-unit-tests
branch
from
May 21, 2026 21:49
3ee4f2d to
39455d8
Compare
Contributor
Author
|
Thanks for the suggestions @Dosik13! I've addressed all points:
|
Dosik13
approved these changes
May 22, 2026
Dosik13
left a comment
Contributor
There was a problem hiding this comment.
lgtm! Thank you for the great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add comprehensive unit test coverage for LiveHash type
The LiveHash struct required additional test coverage for serialization, deserialization, and error handling paths. This PR adds five unit tests covering:
Related issue(s):
Fixes #1713
Notes for reviewer:
All tests pass successfully:
The deprecated duration test confirms the invariant is properly wired in the codebase - the deprecated
Durationfield (time.Time) is not serialized, onlyLiveHashDuration(time.Duration) is used.Checklist