fix: mirror node contract query - #1767
Merged
Merged
Conversation
Signed-off-by: Rado M <radkomih@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
need to perform the e2e tests |
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
can you add more test coverage? |
Signed-off-by: Rado M <radkomih@gmail.com>
Dosik13
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix flaky mirror-node contract-query e2e tests that intermittently failed with an EOF transport error when the local JSON-RPC relay dropped connections under load. performContractCallToMirrorNode used a bare http.Post with no timeout or retry, so a transient connection drop surfaced as an unhandled transport error instead of being retried or returning the intended HTTP result.
Add a shared mirror-node POST helper with bounded retries, backoff, and an explicit timeout, and route the contract query and fee-estimate query through it.
Related issue(s):
Fixes #1752
Fixes #1753
Notes for reviewer:
Both issues share the same root cause (the bare http.Post in performContractCallToMirrorNode), so this single change closes both. 4xx responses are intentionally not retried, preserving the "received non-200 response from Mirror Node" assertion in TestMirrorNodeContractQueryFailWhenGasLimitIsLow (#1752), while transient EOF/5xx are now retried, fixing the TestUint8*/TestUint16* success-path flakiness (#1753).
Checklist