test(1781): assert token balance via mirror node (HIP-367) - #1785
Closed
radkomih wants to merge 4 commits into
Closed
test(1781): assert token balance via mirror node (HIP-367)#1785radkomih wants to merge 4 commits into
radkomih wants to merge 4 commits into
Conversation
Signed-off-by: Rado M <radkomih@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Restore the token balance and decimals assertions in TestIntegrationAccountBalanceQueryCanGetTokenBalance, which were previously commented out. Since HIP-367 removed token balances from the consensus AccountBalanceQuery response, the assertions now query the mirror node as the source of truth.
Related issue(s):
Fixes #1781
Notes for reviewer:
The consensus AccountBalanceQuery still runs to confirm the query succeeds, but token-level assertions are made against the mirror node since HIP-367 no longer returns token balances in the consensus response.
Checklist