fix: honor payment tx id if present - #1790
Merged
Dosik13 merged 1 commit intoJul 27, 2026
Merged
Conversation
Signed-off-by: Rado M <radkomih@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Honor SetPaymentTransactionID when generating query payments so an explicitly-set payment transaction ID is used instead of being silently replaced by a freshly generated one.
Related issue(s):
Fixes #1782
Notes for reviewer:
The setter stored the ID in q.paymentTransactionIDs, but generatePayments always called TransactionIDGenerate(...) and never read it back, so the setter was a no-op across all query types. The fix reads the current ID from the slice when it is non-empty.
Checklist