chore: scope the SA1019 exclusion to protobuf deprecations - #1816
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Signed-off-by: dosi <dosi.kolev@limechain.tech>
Dosik13
force-pushed
the
fix/lint-sa1019-staticcheck
branch
from
August 20, 2026 11:23
32aac61 to
2121fff
Compare
Dosik13
marked this pull request as ready for review
August 20, 2026 11:25
Dosik13
changed the title
radkomih
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Golangci-lint v2.13.0 began reporting SA1019 for HAPI protobuf fields the SDK must keep reading for wire compatibility, turning CI red on every branch. Exclude those findings without disabling deprecation reporting for the SDK's other dependencies.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist