Skip to content

chore: Converted TCK response classes to records - #2920

Open
manishdait wants to merge 3 commits into
hiero-ledger:mainfrom
manishdait:chore/convert-dto-records
Open

chore: Converted TCK response classes to records#2920
manishdait wants to merge 3 commits into
hiero-ledger:mainfrom
manishdait:chore/convert-dto-records

Conversation

@manishdait

@manishdait manishdait commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description:
This PR converts the tck response classes to the records

Related issue(s):

Fixes #2891

Notes for reviewer:

  • Updated parameters type for ContractCallResponse class to use string instead of raw Hbar and AccountId class.
  • Tested against hiero-sdk-tck with solo version 0.87.1
Screenshot From 2026-08-30 18-38-03

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait

Copy link
Copy Markdown
Contributor Author

@mustafauzunn @hendrikebbers, have a question regarding the TCK docs for ContractCallResponse
The fields documented in the TCK spec appear to differ from the fields int the ContractCallResponse class.

See Here:
Tck Docs
ContractCallResponse Class

Should TCK dos updated to match the current ContractCallResponse class, or is the class expected to expose the fields defined in the TCK spec?

Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
manishdait marked this pull request as ready for review August 31, 2026 05:34
@manishdait
manishdait requested review from a team as code owners August 31, 2026 05:34
@manishdait
manishdait requested a review from emiliyank August 31, 2026 05:34
@mustafauzunn

Copy link
Copy Markdown
Contributor

@manishdait
TCK docs should be updated to match the current ContractCallResponse class

@mustafauzunn mustafauzunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fileds javadoc dropped during conversion

Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait

Copy link
Copy Markdown
Contributor Author

Some fileds javadoc dropped during conversion

yay, that were giving the warning: [dangling-doc-comments] documentation comment is not attached to any declaratio.. and failing the build. so i remove them :) . but i have added them in the proper place now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert the 21 response DTOs to records

2 participants