[Intermediate]: Refactor and test .github/workflows/bot-linked-issue-enforcer.yml to have daily closes

[exploreriii]

🧩 Intermediate Contributors

This issue is intended for contributors who already have some familiarity with the
Hiero Python SDK codebase and contribution workflow.

You should feel comfortable:

• navigating existing source code and examples
• understanding SDK concepts without step-by-step guidance
• following the standard PR workflow without additional onboarding

If this is your very first contribution to the project, we recommend starting with a few
Good First Issues before working on this one.

🐞 Problem Description

We have
.github/workflows/bot-linked-issue-enforcer.yml
and
.github/scripts/linked_issue_enforce.js

These currently:

• runs on Monday and Thursday
• check a pull request has been open for 3 days
• closes it if the pull request is not linked to an issue, or the person is not assigned

We would like to tighten these guards

The cron job should:

• run daily at e.g. 2am UTC
• check a pull request has been open for at least 12 hours
• close if the pull request is not linked to an issue, or the person is not assigned to the issue

NOTE: this is a very sensitive workflow, because it can close PRs, you should take care to make minimal changes and test it works
To test it works, you'll need to simulate data and also run it on your fork with e.g. 5 minute windows
You want to ensure the dry mode continues to work and be an option
This is why it is an intermediate issue

💡 Expected Solution

Change the cron trigger to once a day and threshold that a PR will be closed as 12 hours not 3 days

🧠 Implementation Notes

Edit
.github/workflows/bot-linked-issue-enforcer.yml

change the cron trigger to daily at 2am UTC

change
DAYS_BEFORE_CLOSE: '3'
to
HOURS_BEFORE_CLOSE: '12'

Then edit
.github/scripts/linked_issue_enforce.js

ensuring a PR that is greater than 12 hours old will be closed if they are not linked to an issue, or if they are linked to an issue but not assigned

This needs to be robustly tested with real github data

✅ Acceptance Criteria

To merge this issue, the pull request must:

• Fully address the problem described above
• Follow existing project conventions and patterns
• Include tests or example updates where appropriate
• Pass all CI checks
• Include a valid changelog entry
• be a DCO and GPG key signed as git commit -S -s -m "chore: my change" with a GPG key set up

📚 Additional Context or Resources

• SDK Developer Docs
• SDK Developer Training

[github-actions]

🚨 Attention Team 🚨

@hiero-ledger/hiero-sdk-python-maintainers @hiero-ledger/hiero-sdk-python-committers @hiero-ledger/hiero-sdk-python-triage

A new P0 issue has been created: #1863 - [Intermediate]: Refactor and test .github/workflows/bot-linked-issue-enforcer.yml to have daily closes
Please prioritize this issue accordingly.

Best Regards,
Automated Notification System

[github-actions]

@coderabbitai plan

[coderabbitai]

Coding Plan

Summary

• Minimal, focused changes to two files: update cron schedule to daily at 2am UTC and convert threshold from days to hours
• Maintain existing dry-run mode, fail-safe behavior, and PR comment messages unchanged
• Follow documented fork testing patterns with accelerated timescales to validate behavior before merging
• Script changes are semantic renames and calculation adjustments only, preserving all existing validation logic

Implementation Steps

Phase 1: Configuration and Logic Updates

Update the workflow schedule and threshold configuration, then modify the JavaScript script to use hours-based calculation instead of days.

Task 1: Update Workflow Configuration

Change the cron schedule and environment variable in the workflow file.

• Update .github/workflows/bot-linked-issue-enforcer.yml cron schedule from '45 11 * * 1,4' to '0 2 * * *' (daily at 2am UTC)
• Rename environment variable from DAYS_BEFORE_CLOSE: '3' to HOURS_BEFORE_CLOSE: '12'
• Verify dry-run configuration and manual trigger settings remain unchanged

Task 2: Update Script Time Calculation

Modify the JavaScript script to work with hours instead of days.

• Update .github/scripts/linked_issue_enforce.js to read HOURS_BEFORE_CLOSE environment variable instead of DAYS_BEFORE_CLOSE, with default value of '12'
• Rename getDaysOpen() function to getHoursOpen() and modify calculation to return hours: divide milliseconds by (60 * 60 * 1000) instead of (24 * 60 * 60 * 1000)
• Update the variable name from daysBeforeClose to hoursBeforeClose throughout the script
• Update comparison logic to use hours threshold
• Update console.log message on line 123 to reference "hours" instead of "days" (e.g., "is only ${hours} hours old")
• Update the script header comment on line 1 from "after 3 days" to "after 12 hours"

🤖 Prompt for AI agents

This phase updates the linked issue enforcer bot configuration and logic to run
daily with a 12-hour threshold instead of twice weekly with a 3-day threshold.

**Workflow Configuration Changes:**
- In `.github/workflows/bot-linked-issue-enforcer.yml`:
- Change the cron schedule from `'45 11 * * 1,4'` (Monday/Thursday at 11:45 UTC)
to `'0 2 * * *'` (daily at 2am UTC)
- Rename the environment variable from `DAYS_BEFORE_CLOSE: '3'` to
`HOURS_BEFORE_CLOSE: '12'`
- Keep all other configurations (dry-run mode, manual trigger settings)
unchanged

**Script Time Calculation Changes:**
- In `.github/scripts/linked_issue_enforce.js`:
- Change the environment variable reference from `DAYS_BEFORE_CLOSE` to
`HOURS_BEFORE_CLOSE` with default value '12'
  - Rename the `getDaysOpen()` function to `getHoursOpen()`
- Update the time calculation in `getHoursOpen()` to divide milliseconds by `(60
* 60 * 1000)` instead of `(24 * 60 * 60 * 1000)` to calculate hours
- Rename the variable `daysBeforeClose` to `hoursBeforeClose` throughout the
script
  - Update all comparison logic that uses the threshold to work with hours
- Update the console.log message on line 123 to reference "hours" instead of
"days" (e.g., "is only ${hours} hours old")
  - Update the header comment on line 1 from "after 3 days" to "after 12 hours"

These are semantic renames and calculation adjustments only - preserve all
existing validation logic, fail-safe behavior, and PR comment messages.

Phase 2: Testing and Validation

Verify the changes work correctly using fork testing with accelerated timescales, following the documented testing patterns.

Task 1: Fork Testing Setup

Prepare a personal fork for testing the workflow changes.

• Fork the repository and enable GitHub Actions in fork settings
• Merge the implementation changes to the fork's main branch to activate the workflow
• Temporarily modify HOURS_BEFORE_CLOSE to '0' for immediate triggering during tests
• Optionally adjust cron to '*/5 * * * *' (every 5 minutes) for faster iteration during testing

Task 2: Dry-Run Mode Validation

Verify dry-run mode continues to function correctly.

• Manually trigger the workflow via GitHub Actions UI with dry_run: true
• Create test PRs without linked issues in the fork
• Verify console output shows [DRY RUN] Would close PR #... messages with correct hour calculations
• Confirm no PRs are actually closed or commented on

Task 3: Live Mode Validation

Test the actual PR closing behavior in the fork.

• Manually trigger the workflow with dry_run: false
• Verify PRs older than the threshold (with HOURS_BEFORE_CLOSE: '0') are correctly closed
• Verify PR comments are posted with the correct messages
• Verify PRs with properly linked issues and author assignment are not closed
• Restore production configuration values after successful testing

Task 4: Edge Case Verification

Validate edge cases and boundary conditions.

• Test with PRs exactly at the threshold boundary (e.g., 11 hours old vs 13 hours old)
• Verify bot-authored PRs continue to be skipped
• Verify API error handling still fails safe (marks PR as valid)
• Test both no_issue and not_assigned closure reasons

🤖 Prompt for AI agents

This phase validates the linked issue enforcer bot changes through fork testing
with accelerated timescales. No code changes are required - this is a testing
and validation phase.

**Fork Testing Setup:**
- Fork the repository and enable GitHub Actions in the fork settings
- Merge the implementation changes to the fork's `main` branch to activate the
workflow
- Temporarily set `HOURS_BEFORE_CLOSE` to `'0'` for immediate triggering during
tests
- Optionally adjust the cron schedule to `'*/5 * * * *'` (every 5 minutes) for
faster iteration

**Dry-Run Mode Validation:**
- Manually trigger the workflow via GitHub Actions UI with `dry_run: true`
- Create test PRs without linked issues in the fork
- Verify console output shows `[DRY RUN] Would close PR #...` messages with
correct hour calculations
- Confirm no PRs are actually closed or commented on

**Live Mode Validation:**
- Manually trigger the workflow with `dry_run: false`
- Verify PRs older than the threshold (using `HOURS_BEFORE_CLOSE: '0'`) are
correctly closed
- Verify PR comments are posted with the correct messages
- Verify PRs with properly linked issues and author assignment are not closed
- Restore production configuration values (`HOURS_BEFORE_CLOSE: '12'`, daily
cron) after successful testing

**Edge Case Verification:**
- Test PRs at the threshold boundary (e.g., 11 hours old vs 13 hours old with
`HOURS_BEFORE_CLOSE: '12'`)
- Verify bot-authored PRs continue to be skipped
- Verify API error handling still fails safe (marks PR as valid)
- Test both closure reasons: `no_issue` and `not_assigned`

Research

The linked issue enforcer consists of two files: .github/workflows/bot-linked-issue-enforcer.yml (workflow configuration with cron schedule and environment variables) and .github/scripts/linked_issue_enforce.js (enforcement logic). The workflow currently runs Monday/Thursday at 11:45 UTC with a 3-day threshold. The script calculates PR age in days using getDaysOpen(), reads DAYS_BEFORE_CLOSE from environment, and implements dry-run mode for safe testing. PR closure messages are generic and do not mention time thresholds, so they need no changes.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

This phase updates the linked issue enforcer bot configuration and logic to run
daily with a 12-hour threshold instead of twice weekly with a 3-day threshold.

**Workflow Configuration Changes:**
- In `.github/workflows/bot-linked-issue-enforcer.yml`:
- Change the cron schedule from `'45 11 * * 1,4'` (Monday/Thursday at 11:45 UTC)
to `'0 2 * * *'` (daily at 2am UTC)
- Rename the environment variable from `DAYS_BEFORE_CLOSE: '3'` to
`HOURS_BEFORE_CLOSE: '12'`
- Keep all other configurations (dry-run mode, manual trigger settings)
unchanged

**Script Time Calculation Changes:**
- In `.github/scripts/linked_issue_enforce.js`:
- Change the environment variable reference from `DAYS_BEFORE_CLOSE` to
`HOURS_BEFORE_CLOSE` with default value '12'
  - Rename the `getDaysOpen()` function to `getHoursOpen()`
- Update the time calculation in `getHoursOpen()` to divide milliseconds by `(60
* 60 * 1000)` instead of `(24 * 60 * 60 * 1000)` to calculate hours
- Rename the variable `daysBeforeClose` to `hoursBeforeClose` throughout the
script
  - Update all comparison logic that uses the threshold to work with hours
- Update the console.log message on line 123 to reference "hours" instead of
"days" (e.g., "is only ${hours} hours old")
  - Update the header comment on line 1 from "after 3 days" to "after 12 hours"

These are semantic renames and calculation adjustments only - preserve all
existing validation logic, fail-safe behavior, and PR comment messages.
===============================================================================

Task: 2

This phase validates the linked issue enforcer bot changes through fork testing
with accelerated timescales. No code changes are required - this is a testing
and validation phase.

**Fork Testing Setup:**
- Fork the repository and enable GitHub Actions in the fork settings
- Merge the implementation changes to the fork's `main` branch to activate the
workflow
- Temporarily set `HOURS_BEFORE_CLOSE` to `'0'` for immediate triggering during
tests
- Optionally adjust the cron schedule to `'*/5 * * * *'` (every 5 minutes) for
faster iteration

**Dry-Run Mode Validation:**
- Manually trigger the workflow via GitHub Actions UI with `dry_run: true`
- Create test PRs without linked issues in the fork
- Verify console output shows `[DRY RUN] Would close PR #...` messages with
correct hour calculations
- Confirm no PRs are actually closed or commented on

**Live Mode Validation:**
- Manually trigger the workflow with `dry_run: false`
- Verify PRs older than the threshold (using `HOURS_BEFORE_CLOSE: '0'`) are
correctly closed
- Verify PR comments are posted with the correct messages
- Verify PRs with properly linked issues and author assignment are not closed
- Restore production configuration values (`HOURS_BEFORE_CLOSE: '12'`, daily
cron) after successful testing

**Edge Case Verification:**
- Test PRs at the threshold boundary (e.g., 11 hours old vs 13 hours old with
`HOURS_BEFORE_CLOSE: '12'`)
- Verify bot-authored PRs continue to be skipped
- Verify API error handling still fails safe (marks PR as valid)
- Test both closure reasons: `no_issue` and `not_assigned`

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!

[exploreriii]

Closed as completed in #1897