Skip to content

Update spam-list.txt with new spam accounts - #1936

Closed
qawine wants to merge 1 commit into
hiero-ledger:mainfrom
qawine:main
Closed

Update spam-list.txt with new spam accounts#1936
qawine wants to merge 1 commit into
hiero-ledger:mainfrom
qawine:main

Conversation

@qawine

@qawine qawine commented Mar 8, 2026

Copy link
Copy Markdown

Fixes #1933

Added the following spam accounts to .github/spam-list.txt:

  • Halbot100
  • roberthallers

@qawine
qawine requested review from a team as code owners March 8, 2026 04:07
@coderabbitai

coderabbitai Bot commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Updates .github/spam-list.txt by adding new spam list entries (Halbot100 and roberthallers) with zhanglinqian retained. Change consists of 3 lines added and 1 line removed.

Changes

Cohort / File(s) Summary
Spam List Update
.github/spam-list.txt
Adds Halbot100 and roberthallers to spam list; retains zhanglinqian. Net change of +3/-1 lines.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially addresses issue #1933 by adding Halbot100 and roberthallers but omits SergioChan, one of the three required usernames. Add SergioChan to .github/spam-list.txt to fully satisfy the requirements specified in issue #1933.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: updating the spam-list.txt file with new spam accounts.
Description check ✅ Passed The description is directly related to the changeset, referencing issue #1933 and listing the spam accounts being added.
Out of Scope Changes check ✅ Passed All changes are limited to .github/spam-list.txt as required by issue #1933, with no modifications to other files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f921fa1e-0225-48d1-b0ac-c4a66c222ff8

📥 Commits

Reviewing files that changed from the base of the PR and between 90f1673 and b1cdcf0.

📒 Files selected for processing (1)
  • .github/spam-list.txt

Comment thread .github/spam-list.txt
Comment on lines +4 to +6
zhanglinqian
Halbot100
roberthallers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider alphabetical sorting for better maintainability.

The spam list could benefit from alphabetical ordering to make it easier to detect duplicates and maintain the list over time. While the existing entries aren't alphabetically sorted, establishing this pattern now would improve long-term maintainability.

♻️ Proposed alphabetical ordering
-KubanjaElijahEldred
 by22Jy
 CODEAbhinav-art
-zhanglinqian
 Halbot100
+KubanjaElijahEldred
 roberthallers
+SergioChan
+zhanglinqian

⚠️ Potential issue | 🔴 Critical

Missing required username: SergioChan.

Issue #1933 explicitly requests adding three usernames (Halbot100, roberthallers, and SergioChan), but this PR only adds two. SergioChan is missing from the spam list.

🐛 Proposed fix to add the missing username
 zhanglinqian
 Halbot100
 roberthallers
+SergioChan
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
zhanglinqian
Halbot100
roberthallers
zhanglinqian
Halbot100
roberthallers
SergioChan

@manishdait

Copy link
Copy Markdown
Contributor

@qawine, Please get assigned so we can review this #1933

@exploreriii

Copy link
Copy Markdown
Contributor

Hi @qawine please get assigned and ensure you complete the issue fully; closing this PR meanwhile.
Feel free to reopen once you are assigned

@exploreriii exploreriii closed this Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Update spam-list.txt

3 participants