chore: update Hedera protobufs to v0.76.1 - #2589
Conversation
Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
|
Hi, this is WorkflowBot.
|
|
Hello, this is the OfficeHourBot. This is a reminder that the Hiero Python SDK Office Hours will begin in approximately 3 hours and 49 minutes (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here for any changes. From, |
Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
|
Warning This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged. WalkthroughChangesProtobuf and Hiero version updates
Node account transaction signing
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: 🔵 Low · up to The protobuf version update is localized and mergeable with explicit owner follow-up: the integration test should verify that the registered node is actually associated with the created node, since checking only transaction success could allow that behavior to regress unnoticed. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes update the documented protobuf version, workflow Hiero version, and generator source version to v0.76.1. The generator import exclusion and node transaction signing changes support compatibility and the linked issue objectives [ Full details: Docstring CoverageExplanation Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 5 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ada3c9a8-f0c3-484d-9598-23822afeafea
📒 Files selected for processing (8)
.coderabbit.yaml.github/workflows/pr-check-secondary-examples.yml.github/workflows/pr-check-secondary-unit-integration-test.ymlexamples/nodes/node_create_transaction.pyexamples/nodes/node_delete_transaction.pyexamples/nodes/node_update_transaction.pygenerate_proto.pytests/integration/associated_registered_nodes_e2e_test.py
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
manishdait
left a comment
There was a problem hiding this comment.
lgtm! for signing changes, this transaction will most likely be used with an admin account eg 0.0.2 on solo. It is likely that sdk users will use it as well, but I think it would be better to mention this change in the release changelog on relase
exploreriii
left a comment
There was a problem hiding this comment.
You might have to change
change what? |
|
👋 Hi @MonaaEid! Great work completing a Intermediate issue! 🎉 Thanks for your contribution! 🚀 Here are some issues you might want to explore next:
🌟 Stay connected: Happy coding! 🚀 |
Description:
This pull request updates the Hedera protobuf and Hiero SDK versions used throughout the project to
v0.76.1.Version updates:
.coderabbit.yamlto referencehedera-protobufsversionv0.76.1instead ofv0.72.0-rc.2.hieroVersionin the GitHub Actions workflows (pr-check-secondary-examples.ymlandpr-check-secondary-unit-integration-test.yml) tov0.76.1. * Updated theVERSIONconstant ingenerate_proto.pytov0.76.1.Related issue(s):
Fixes #2588
Notes for reviewer:
Checklist