feat(tck): implement unpauseToken JSON-RPC method - #2613
Conversation
Signed-off-by: anchit-goel <anchitgoel5@gmail.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe TCK now supports the ChangesUnpauseToken RPC
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The PR adds the unpauseToken RPC path and related tests. The implementation is localized, but the integration tests should verify the exact error code and use a token ID guaranteed not to exist, avoiding misleading or environment-dependent results. This bounded test-readiness risk is mergeable with explicit follow-up. Sequence Diagram(s)sequenceDiagram
participant Client
participant unpause_token
participant TokenUnpauseTransaction
participant Network
Client->>unpause_token: unpauseToken parameters
unpause_token->>TokenUnpauseTransaction: Build and execute transaction
TokenUnpauseTransaction->>Network: Submit transaction
Network-->>unpause_token: Return transaction receipt
unpause_token-->>Client: UnpauseTokenResponse
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a81490f5-d2d7-4de4-9907-464e33f657e7
📒 Files selected for processing (3)
src/hiero_sdk_python/tokens/token_unpause_transaction.pytests/integration/token_unpause_transaction_e2e_test.pytests/unit/token_unpause_transaction_test.py
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bf787b6d-0c29-49cb-9175-4230a6d88a59
📒 Files selected for processing (2)
src/hiero_sdk_python/tokens/token_unpause_transaction.pytests/unit/token_unpause_transaction_test.py
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
…useTransaction unit tests Signed-off-by: anchit-goel <anchitgoel5@gmail.com>
danielmarv
left a comment
There was a problem hiding this comment.
Please address pre-commit errors
Signed-off-by: anchit-goel <anchitgoel5@gmail.com>
there is a issue with uv.lock file it seems, it gets changed everytime, I try to find out a solution. |
danielmarv
left a comment
There was a problem hiding this comment.
please rectify the issue with the intergration tests coz they are not passing
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: e76ec288-224a-4f71-bd34-97e01e9835b3
📒 Files selected for processing (1)
tests/integration/token_unpause_transaction_e2e_test.py
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
…unpause_transaction_e2e_test.py Signed-off-by: anchit-goel <anchitgoel5@gmail.com>
7872878 to
04fe25e
Compare
…ork-guaranteed invalid TokenId Signed-off-by: anchit-goel <anchitgoel5@gmail.com>
|
some commits are not having the gpg signing |
|
resolved that issue. all commits in this branch should now be signed. |
|
aah sorry for that mine was stale |
|
test runs complete. |
|
@anchit-goel, Thanks for the PR :) |
|
👋 Hi @anchit-goel! Great work completing a Beginner issue! 🎉 Thanks for your contribution! 🚀 🏆 Milestone unlocked: you've reached Intermediate level! 🎉 Here are some issues you might want to explore next:
🌟 Stay connected: Happy coding! 🚀 |
Description:
Implement the
unpauseTokenTCK JSON-RPC method by mirroring the existingpauseTokenimplementation across the TCK token parameters, responses, and RPC handler modules.UnpauseTokenParamsdataclass inheriting fromBaseTransactionParamswithtokenIdandparse_json_paramsintck/param/token.pyUnpauseTokenResponsestatus-only dataclass intck/response/token.py_build_unpause_token_transactionhelper and@rpc_method("unpauseToken")handler intck/handlers/token.pyRelated issue(s):
Fixes #2420
Notes for reviewer:
pauseTokenintck/handlers/token.py,tck/param/token.py, andtck/response/token.py.handle_sdk_errorsto map validation errors to JSON-RPC errors.uv run pytest tests/unit/token_unpause_transaction_test.py) and code style tools (ruff check tck/&ruff format --check tck/).Checklist