Skip to content

Rewrite plain-text @nick as an IRC highlight - #322

Open
rollecode wants to merge 2 commits into
hifi:masterfrom
rollecode:feature/plaintext-nick-highlight
Open

Rewrite plain-text @nick as an IRC highlight#322
rollecode wants to merge 2 commits into
hifi:masterfrom
rollecode:feature/plaintext-nick-highlight

Conversation

@rollecode

@rollecode rollecode commented Aug 27, 2026

Copy link
Copy Markdown

On Beeper, manually typing @alice hello (not using the client's mention autocomplete, so no pill, no m.mentions) currently relays to IRC as the literal string @alice hello instead of the usual IRC highlight convention alice: hello.

This only rewrites the message when the word right after @ matches a nick actually on the channel right now (is_on_channel), so it never invents a mapping for a name that isn't there.

Related but distinct from two earlier threads worth reconsidering here:

Given that, happy to discuss if this should still be opt-in via a room setting, but wanted to raise it since the earlier objections don't seem to carry over directly.

@rollecode

Copy link
Copy Markdown
Author

Generalized this: the first commit only rewrote a mention opening the message. Second commit strips @ anywhere in the text (still gated on is_on_channel), since what's up @nick was still showing the literal @ mid-message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant