Cleanly separates out the Elements Compiler languages from their official couterparts#4364
Cleanly separates out the Elements Compiler languages from their official couterparts#4364dwarfland wants to merge 17 commits into
Conversation
# Conflicts: # src/languages/csharp.js # src/languages/go.js # src/languages/java.js
|
Hi @allejo, could you please approve the CI workflow run for this PR? |
Build Size ReportChanges to minified artifacts in 8 Added FilesView Changes
9 files changedTotal change +710 B View Changes
|
|
Don't mind the noise, just had to close + re-open this PR so that I could trigger the workflows. But now we know there's a failing build 😄 |
|
@allejo could you re-open this PR please? |
|
@allejo could you re-open this PR? |
Build Size ReportChanges to minified artifacts in 8 Added FilesView Changes
9 files changedTotal change +845 B View Changes
|
|
@joshgoebel need your approve. |
|
@joshgoebel could you please take a look at this PR? |
|
@joshgoebel could you please take a look at this PR? |
|
@joshgoebel , @allejo could you please take a look at this PR? |
Can you please elaborate on this? Generally we don't merge new languages into core, but maybe there is an exception here IF they already existed but under different names. I need to understand the full story here to understand how to judge this. |
Sure! Elements is a compiler family from RemObjects since 2005: Oxygene (Object Pascal) plus dialects of C# (Hydrogene), Java (Iodine), Go (Gold), VB.NET (Mercury) and Swift (Silver) same official syntax. Oxygene has been in core since 2013 and we have maintained it since. The other dialects never had their own grammars in our fork their extra keywords were historically patched straight into the base The recent commits undo that mixing: the dialects became standalone grammars ( |
Changes
oxygene,hydrogene,iodinesilver,goldvbmercuryas named languagesfieldkeyword fo csharp & hydrogene