-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add Concrete Table Inheritance as alternative inheritance strategy #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joamag
wants to merge
14
commits into
master
Choose a base branch
from
feat/concrete-table-inheritance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e780b2a
feat: add Concrete Table Inheritance as alternative inheritance strategy
joamag 33cf982
test: expand ORM unit test coverage with edge case tests
joamag 3dad2b8
test: add migration tests for validate, dry-run, backup, and rollback
joamag 3f52c19
test: add backup data integrity, migrate-backup, and backup-failure t…
joamag 5d784f0
fix: resolve CI failures on Python 2.7 and Windows
joamag 23b44bd
fix: skip migration tests on Python 2.7 where importlib.util is unava…
joamag 8465932
feat: add inheritance strategy benchmark script
joamag c217fab
feat: add wide hierarchy benchmark (60 columns) to show crossover point
joamag aadbcb2
feat: redesign concrete table to populate all ancestor tables
joamag a63831f
chore: small design test change
joamag 68632e4
feat: rewrite migration tool for production use with end-to-end tests
joamag 47dbdbb
feat: add DATA_INHERITANCE global config override
joamag f8e030e
refactor: move migration tests to scripts/test/ and add multi-engine …
joamag 5c3626e
feat: Add lazy evaluation support to model logging methods
joamag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bossis paired with the wrong reverse relation.Using
reverse="children"ties manager lookups to the parent/child relation metadata.ConcretePersonneeds a dedicated report collection here; otherwise reverse traversal and lazy loading for boss relationships will resolve the wrong side.🐛 Suggested fix
class ConcretePerson(ConcreteRootEntity): @@ children = dict(type="relation") """ The children of the current person """ + employees = dict(type="relation") + """ The employees associated with the person """ + @@ def _relation_children(): return dict(type="to-many", target=ConcretePerson, reverse="parent") + `@staticmethod` + def _relation_employees(): + return dict(type="to-many", target=ConcreteEmployee, reverse="boss") + @@ class ConcreteEmployee(ConcretePerson): @@ `@staticmethod` def _relation_boss(): return dict( - type="to-one", target=ConcretePerson, reverse="children", is_mapper=True + type="to-one", target=ConcretePerson, reverse="employees", is_mapper=True )🤖 Prompt for AI Agents