FHIR-58774: set BodyStructure includedStructure extension to 1..* - #21
Merged
patrick-werner merged 1 commit intoSep 1, 2026
Merged
Conversation
The R5 cross-version extension BodyStructure.includedStructure defines its root element as 1..*, derived from the R5 source element. The R4 profile constrained the slice to 0..*, which no tooling reports because the extension definition's root cardinality is not enforced at the point of use. The R5 variant needs no change: BodyStructure.includedStructure is 1..* in the base resource. Also adds an example with two included structures, multiple qualifiers and a business identifier.
patrick-werner
deleted the
FHIR-58774-bodystructure-includedstructure-cardinality
branch
September 4, 2026 08:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TC: https://jira.hl7.org/browse/FHIR-58774
BodyStructureEuCoreconstrainedextension:includedStructureto0..*, while the cross-version extensionhttp://hl7.org/fhir/5.0/StructureDefinition/extension-BodyStructure.includedStructuredefines its root element as1..*, derived from the R5 source elementBodyStructure.includedStructure 1..*.The mismatch is not reported by any tooling: SUSHI validates the
containscardinality only against the base elementBodyStructure.extension(0..*), the snapshot generator takes min/max from the differential slice, and the validator evaluates an extension definition only when an extension instance is actually present.The constraint is also the only way to express the body site in this profile, since
locationandlocationQualifierare0..0— so aBodyStructureEuCoreinstance withoutincludedStructurecarries no anatomic location at all.Changes
extension:includedStructureset to1..*. The R5 variant needs no change,BodyStructure.includedStructureis1..*in the base resource.BodyStructureMultipleIncludedStructuresExample: a lesion extending over the left wrist and the distal left forearm, with twoincludedStructureentries, multiplequalifiervalues and a business identifier. Rendered for both R4 (extension syntax) and R5 (native element).Both variants render and build with SUSHI: 0 errors, 0 warnings.