FHIR-57053: compare the distinguishing properties in the report invariants - #132
Open
patrick-werner wants to merge 1 commit into
Open
FHIR-57053: compare the distinguishing properties in the report invariants#132patrick-werner wants to merge 1 commit into
patrick-werner wants to merge 1 commit into
Conversation
…iants dr-comp-type now compares system, version and code, dr-comp-identifier system and value, instead of the complete Coding and Identifier elements. The implication of dr-comp-identifier is limited to DiagnosticReport.identifier, matching its description. dr-comp-category was removed, as the category of the document and the medical discipline of the report are not the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves FHIR-57053 (Persuasive with Modification).
Changes
dr-comp-type— "change the comparison to system + code + version":dr-comp-category— removed, together with its* obeyson the Bundle profile ("Category of DR and Composition could be not the same, one is the categorization of the document, the other one about the medical discipline of the DR").dr-comp-identifier— same comparison approach:&is used rather than+so that codings without aversionstill produce a comparable string instead of dropping out.Points that needed a call
dr-comp-identifieras well;Identifierhas neithercodenorversion, so the analogous propertiessystemandvalueare compared — as the issue description proposed.DiagnosticReport.identifier.exists(). With the previousorthe invariant failed when only the Composition carried an identifier, which its description never claimed. This was raised in the issue description but not repeated in the resolution.dr-comp-categorygone, the comment "DiagnosticReport.category and Composition.category shall be aligned" inReportCategoryRulewould have contradicted the resolution, so it was removed (affectsComposition.categoryandDiagnosticReport.category).All example bundles satisfy both invariants (checked
type/codecodings and identifiers of Composition and DiagnosticReport in the five generated bundles). SUSHI: 0 errors.