service data#6
Merged
Merged
Conversation
tony-go
requested changes
Jun 8, 2026
tony-go
requested changes
Jun 9, 2026
sethvincent
force-pushed
the
java-threads-service-data
branch
from
b237047 to
33d072c
Compare
Contributor
Author
|
I had to rebase against main because I goofed on the pr stacking. @tony-go I made your suggested changes locally and then I also changed things up a bit 😬 The jstl args suggestion removed 700+ lines of code, so that was lovely. |
tony-go
requested changes
Jun 10, 2026
|
@sethvincent Just a last check on https://github.com/holepunchto/bare-bluetooth-android/pull/6/changes#r3397302221 otherwise it looks good :) |
tony-go
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this builds on #5 to add service data support.