holo-interface: restore IP addresses after interface state changes#104
Open
Shbinging wants to merge 1 commit into
Open
holo-interface: restore IP addresses after interface state changes#104Shbinging wants to merge 1 commit into
Shbinging wants to merge 1 commit into
Conversation
Contributor
Author
|
CLOSES #105 |
Fix two bugs that caused configured IP addresses to not be restored
when interface state changes:
1. Interface delete/add (RTM_DELLINK -> RTM_NEWLINK):
- Clear ifindex in remove() when Owner::SYSTEM is removed
- Update ifindex_tree correctly when interface reappears
2. Interface down/up (without RTM_DELLINK):
- Check configured addresses against system addresses on every
RTM_NEWLINK, before the early return check
- Reinstall any missing configured addresses
The root cause was that holo-interface relied on ifindex.is_none()
to trigger address installation, but this condition was not met in
scenarios where addresses were removed by the kernel without the
interface being deleted.
Signed-off-by: Bing Shui <bingshui@smail.nju.edu.cn>
Shbinging
force-pushed
the
fix_ip_address_restore_bug
branch
from
d69e9f6 to
6c4139c
Compare
rwestphal
reviewed
Feb 6, 2026
| iface.ifindex = Some(ifindex); | ||
|
|
||
| let iface = &self.arena[iface_idx]; | ||
| iface.apply_config(ifindex, netlink_tx, self); |
Member
There was a problem hiding this comment.
Why remove iface.apply_config() from here? We definitely want to apply pre-existing MTU, admin status and VLAN config to newly created interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two bugs that caused configured IP addresses to not be restored when interface state changes: