fix(integrations): preserve Nextcloud subpaths - #6295
Conversation
🚨 Preview Deployment Blocked - Security ProtectionYour pull request was blocked from triggering preview deployments Why was this blocked?
How to resolve this:Option 1: Get Collaborator Access (Recommended) Option 2: Request Permission Override For Repository Administrators:To disable this security check ( This security measure protects against malicious code execution in preview deployments. Only trusted collaborators should have the ability to trigger deployments. 🛡️ Learn more about this security featureThis protection prevents unauthorized users from:
Preview deployments are powerful but require trust. Only users with repository write access can trigger them. |
📝 WalkthroughWalkthroughChangesNextcloud CalDAV URL handling
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
/remote.php/dav/endpoint/remote.php/davintegration URLs idempotenttsdavperforms well-known discovery from the origin and therefore drops a configured path such as/nextcloud. Supplying the canonical DAV endpoint as its server URL keeps that path available as a discovery fallback without changing the integration URL used by notifications or external links.Fixes #3597.
Verification
NODE_ENV=development CI=true pnpm exec vitest run packages/integrations/src/nextcloud/test/nextcloud-url.spec.ts packages/integrations/src/nextcloud/test/nextcloud-integration.spec.ts— 5 tests passedpnpm --filter @homarr/integrations typecheck— passedpnpm --filter @homarr/integrations lint— passed with 0 errors (existing package warnings only)pnpm exec oxfmt --checkon all changed files — passedgit diff --check— passedChecklist
pnpm build, autofix withpnpm format:fix) — full build not run; targeted checks are listed abovedevbranch