Configurable time format in ForecastSolar class#330
Conversation
|
Is the codecov path level check a key one here? I.e. would that be blocking getting this merged, or more of a "good to have"? I've held off on adding tests for each possible time format option here as on first glance it would make the fixtures a fair bit bigger with additional expected outputs, but if it's a hard requirement I can plan to put time against scaffolding that out. |
|
Yes, you need to add tests so that the extra lines of code are also tested. ./Klaas |
|
Righto; I'll try to put some time against that over the next while. It might be a bit before I can slot that in, but will plug away at it. |
|
You don't have to do anything complex; it's just testing with the time parameter in the request. There are plenty of other tests you can copy from. ./Klaas |
Permits setting the time format per https://doc.forecast.solar/doku.php?id=api#time
Related to #294
Default time format of
utcis maintained. This merely permits the user to specify the time format to use rather than hard codingutc.