Fix settings update issue by making SensorSetting immutable

[TimoPtr]

Summary

The sensor settings update where not showing as per @jpelgrom found out #7041 (comment) with the recent changes we've made.

I've fixed it by making SensorSetting immutable and exposing StateFlow for it. The issue was that now that the sensor is immutable the way we've updated the Settings it was not triggering a change on the compose side because the object itself was still the same reference.

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

Based on #7041

[jpelgrom]

Tested and this correctly fixes the issue. Thanks for the fix!

[jpelgrom]

You can use a duration here instead of millis which should be preferred. 5 seconds also feels very long for configuration changes.

(This also needs updated imports so simply accepting suggestion won't work)

Suggested change

	private const val STOP_TIMEOUT_MILLIS = 5_000L
	private val STOP_TIMEOUT = 1.seconds

[TimoPtr]

I'm ashamed ... I used claude for this and I didn't even see that it was not following the convention I wrote... 🥹

[TimoPtr]

I also made it 500ms like we had in other places.

[Copilot]

Pull request overview

This PR addresses a regression where sensor setting changes were not reflected in the Compose UI after recent immutability changes, by making SensorSetting immutable and switching the sensor detail screen to consume database-backed StateFlows.

Changes:

• Make SensorSetting.value immutable (var → val)
• Refactor SensorDetailViewModel to expose StateFlow for sensors and sensor settings (via stateIn)
• Update SensorDetailView to collect these flows using collectAsStateWithLifecycle and update dialog submission to use copy(...)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
common/src/main/kotlin/io/homeassistant/companion/android/database/sensor/SensorSetting.kt	Makes sensor setting values immutable to ensure state updates propagate via new instances
app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/views/SensorDetailView.kt	Collects StateFlow values in Compose and updates setting submission to use immutable copies
app/src/main/kotlin/io/homeassistant/companion/android/settings/sensor/SensorDetailViewModel.kt	Exposes sensors/settings as StateFlow backed by database flows using stateIn