Add an sensor for the tonal palette for dynamic colors #7319
+277
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,195 @@ | ||
| package io.homeassistant.companion.android.sensors | ||
|
|
||
| import android.content.Context | ||
| import android.os.Build | ||
| import android.provider.Settings | ||
| import androidx.test.core.app.ApplicationProvider.getApplicationContext | ||
| import dagger.hilt.android.testing.HiltAndroidRule | ||
| import dagger.hilt.android.testing.HiltAndroidTest | ||
| import dagger.hilt.android.testing.HiltTestApplication | ||
| import io.homeassistant.companion.android.common.sensors.SensorRepository | ||
| import io.homeassistant.companion.android.common.util.STATE_UNAVAILABLE | ||
| import io.homeassistant.companion.android.common.util.STATE_UNKNOWN | ||
| import io.homeassistant.companion.android.common.util.kotlinJsonMapper | ||
| import io.homeassistant.companion.android.database.sensor.Attribute | ||
| import io.homeassistant.companion.android.testing.unit.seedFakeAndroidId | ||
| import javax.inject.Inject | ||
| import kotlinx.coroutines.test.runTest | ||
| import org.junit.Assert.assertArrayEquals | ||
| import org.junit.Assert.assertEquals | ||
| import org.junit.Assert.assertFalse | ||
| import org.junit.Assert.assertTrue | ||
| import org.junit.Before | ||
| import org.junit.Rule | ||
| import org.junit.Test | ||
| import org.junit.jupiter.api.assertNotNull | ||
| import org.junit.runner.RunWith | ||
| import org.robolectric.RobolectricTestRunner | ||
| import org.robolectric.annotation.Config | ||
|
|
||
| @HiltAndroidTest | ||
| @RunWith(RobolectricTestRunner::class) | ||
|
Member
There was a problem hiding this comment. Can we avoid Robolectric? Which Android framework classes cannot be mocked?
Author
There was a problem hiding this comment. The
Member
There was a problem hiding this comment. You can mock it though? @Test
fun testSettingsSecure() {
mockkStatic(Settings.Secure::class)
every { Settings.Secure.getString(any(), any()) } returns "my string"
val result = dynamicColorSensor.getSecureSetting()
assertEquals("my string", result)
}
Author
There was a problem hiding this comment. That does work for that call, yes. Trying it out and looking further, this will require substantially more mocking (mocking At that point this will no longer be testing realistic framework behavior. Is there a particular concern with Robolectric? I see other tests in this package are using it already (such as |
||
| @Config(sdk = [36], application = HiltTestApplication::class) | ||
| class DynamicColorSensorManagerTest { | ||
| @get:Rule(order = 0) | ||
| val hiltRule = HiltAndroidRule(this) | ||
|
|
||
| @Inject | ||
| internal lateinit var sensorManager: DynamicColorSensorManager | ||
|
|
||
| @Inject | ||
| internal lateinit var sensorRepository: SensorRepository | ||
|
|
||
| @Before | ||
| fun setUp() { | ||
| getApplicationContext<Context>().seedFakeAndroidId() | ||
| hiltRule.inject() | ||
| } | ||
|
|
||
| @Config(maxSdk = Build.VERSION_CODES.R) | ||
| @Test | ||
| fun `Given SDK is lower than Android 12 then sensor manager is absent`() { | ||
| assertFalse(sensorManager.hasSensor()) | ||
| } | ||
|
|
||
| @Config(minSdk = Build.VERSION_CODES.S) | ||
| @Test | ||
| fun `Given SDK is at least Android 12 then sensor manager is present`() { | ||
| assertTrue(sensorManager.hasSensor()) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given dynamic color sensor when available sensors then includes color and palette sensors`() = runTest { | ||
| val availableSensors = sensorManager.getAvailableSensors() | ||
| assertTrue(availableSensors.contains(DynamicColorSensorManager.accentColorSensor)) | ||
| assertTrue(availableSensors.contains(DynamicColorSensorManager.tonalPaletteSensor)) | ||
| } | ||
|
kcoppock marked this conversation as resolved.
|
||
|
|
||
| @Test | ||
| fun `Given accent color sensor when required permissions then none specified`() { | ||
| assertArrayEquals( | ||
| emptyArray<String>(), | ||
| sensorManager.requiredPermissions(DynamicColorSensorManager.accentColorSensor.id), | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given tonal palette sensor when required permissions then none specified`() { | ||
| assertArrayEquals( | ||
| emptyArray<String>(), | ||
| sensorManager.requiredPermissions(DynamicColorSensorManager.tonalPaletteSensor.id), | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given enabled color sensor when request update then sets theme color`() = runTest { | ||
| val id = DynamicColorSensorManager.accentColorSensor.id | ||
| sensorRepository.setSensorEnabled(id, listOf(1), true) | ||
|
|
||
| sensorManager.requestSensorUpdate() | ||
|
|
||
| val state = sensorRepository.get(id).single().state | ||
|
|
||
| // Default accent color for Robolectric | ||
| assertEquals("#475D92", state) | ||
|
|
||
| val attrs = getSensorAttributes(id) | ||
| val rgbColor = attrs.find { it.name == "rgb_color" } | ||
| assertNotNull(rgbColor) | ||
|
|
||
| // Fixed accent color for Robolectric is 475D92 | ||
| assertEquals("[71,93,146]", rgbColor.value) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given disabled color sensor when request update then does not update state`() = runTest { | ||
| val id = DynamicColorSensorManager.accentColorSensor.id | ||
| sensorRepository.setSensorEnabled(id, listOf(1), false) | ||
|
|
||
| sensorManager.requestSensorUpdate() | ||
|
|
||
| assertEquals("", sensorRepository.get(id).single().state) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given palette sensor when request update then sets palette variant`() = runTest { | ||
| val id = DynamicColorSensorManager.tonalPaletteSensor.id | ||
| sensorRepository.setSensorEnabled(id, listOf(1), true) | ||
|
|
||
| Settings.Secure.putString( | ||
| getApplicationContext<Context>().contentResolver, | ||
| "theme_customization_overlay_packages", | ||
| """{ "android.theme.customization.theme_style": "VIBRANT" }""", | ||
| ) | ||
|
|
||
| sensorManager.requestSensorUpdate() | ||
|
|
||
| assertEquals("VIBRANT", sensorRepository.get(id).single().state) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given palette sensor when receives malformed input then state is unknown`() = runTest { | ||
| val id = DynamicColorSensorManager.tonalPaletteSensor.id | ||
| sensorRepository.setSensorEnabled(id, listOf(1), true) | ||
|
|
||
| Settings.Secure.putString( | ||
| getApplicationContext<Context>().contentResolver, | ||
| "theme_customization_overlay_packages", | ||
| """android.theme.customization.theme_style""", | ||
| ) | ||
|
|
||
| sensorManager.requestSensorUpdate() | ||
|
|
||
| assertEquals(STATE_UNKNOWN, sensorRepository.get(id).single().state) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given palette sensor when receives null input then state is unavailable`() = runTest { | ||
| val id = DynamicColorSensorManager.tonalPaletteSensor.id | ||
| sensorRepository.setSensorEnabled(id, listOf(1), true) | ||
|
|
||
| Settings.Secure.putString( | ||
| getApplicationContext<Context>().contentResolver, | ||
| "theme_customization_overlay_packages", | ||
| null, | ||
| ) | ||
|
|
||
| sensorManager.requestSensorUpdate() | ||
|
|
||
| assertEquals(STATE_UNAVAILABLE, sensorRepository.get(id).single().state) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given palette sensor when updated then options are exhaustive`() = runTest { | ||
| val id = DynamicColorSensorManager.tonalPaletteSensor.id | ||
| sensorRepository.setSensorEnabled(id, listOf(1), true) | ||
|
|
||
| sensorManager.requestSensorUpdate() | ||
|
|
||
| val attrs = getSensorAttributes(id) | ||
| val options = attrs.find { it.name == "options" }?.value | ||
| assertNotNull(options) | ||
|
|
||
| // Serialized as ["EXPRESSIVE","RAINBOW",...] | ||
| val optionsUnwrapped = kotlinJsonMapper.decodeFromString<List<String>>(options) | ||
|
|
||
| assertEquals( | ||
| listOf( | ||
| "EXPRESSIVE", | ||
| "FRUIT_SALAD", | ||
| "MONOCHROMATIC", | ||
| "RAINBOW", | ||
| "SPRITZ", | ||
| "TONAL_SPOT", | ||
| "VIBRANT", | ||
| ).sorted(), | ||
|
jpelgrom marked this conversation as resolved.
|
||
| optionsUnwrapped.sorted(), | ||
| ) | ||
| } | ||
|
|
||
| private suspend fun getSensorAttributes(id: String): List<Attribute> { | ||
| val map = sensorRepository.getFull(id) | ||
| assertEquals(1, map.size) | ||
| return map.values.single() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.