Drop pyserial-asyncio from zha - #116638
Conversation
This may not be possible yet, but the long term goal is to get rid of pyserial-asyncio everywhere so we can prevent future integrations from using it and than we have to go though the effort of getting them to replace it with pyserial-asyncio-fast to avoid the event loop being blocked needed for #116635
|
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
As far as I'm aware, there's nothing ZHA-related that still requires Only zigpy requirements still include |
|
Indeed, this shouldn't have been a ZHA dependency to begin with. It'll be pulled in via zigpy and we can drop it there in a future release. I think we can similarly drop pyserial as well. ZHA doesn't itself depend on it and we can swap it with https://github.com/puddly/serialpy or something in the future, since the zigpy libraries are written to not directly import pyserial in any way. |
|
Thanks |
Proposed change
This may not be possible yet, but the long term goal is to get rid of pyserial-asyncio everywhere so we can prevent future integrations from using it and than we have to go though the effort of getting them to replace it with pyserial-asyncio-fast to avoid the event loop being blocked
needed for #116635
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: