Skip to content

Drop pyserial-asyncio from zha - #116638

Merged
bdraco merged 2 commits into
devfrom
drop_pyserial_zha
May 3, 2024
Merged

Drop pyserial-asyncio from zha#116638
bdraco merged 2 commits into
devfrom
drop_pyserial_zha

Conversation

@bdraco

@bdraco bdraco commented May 2, 2024

Copy link
Copy Markdown
Member

Proposed change

This may not be possible yet, but the long term goal is to get rid of pyserial-asyncio everywhere so we can prevent future integrations from using it and than we have to go though the effort of getting them to replace it with pyserial-asyncio-fast to avoid the event loop being blocked

needed for #116635

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This may not be possible yet, but the long term goal is to get
rid of pyserial-asyncio everywhere so we can prevent future
integrations from using it and than we have to go though the
effort of getting them to replace it with pyserial-asyncio-fast
to avoid the event loop being blocked

needed for #116635
@home-assistant

home-assistant Bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@TheJulianJES

Copy link
Copy Markdown
Member

This may not be possible yet

As far as I'm aware, there's nothing ZHA-related that still requires pyserial-asyncio (instead of pyserial-asyncio-fast).

Only zigpy requirements still include pyserial-asyncio instead of pyserial-asyncio-fast. Currently, the ZHA manifest requires pyserial-asyncio-fast to be installed, so zigpy already always uses that (and thus all zigpy radio libraries).

@bdraco
bdraco marked this pull request as ready for review May 2, 2024 22:27
@puddly

puddly commented May 2, 2024

Copy link
Copy Markdown
Contributor

Indeed, this shouldn't have been a ZHA dependency to begin with. It'll be pulled in via zigpy and we can drop it there in a future release.

I think we can similarly drop pyserial as well. ZHA doesn't itself depend on it and we can swap it with https://github.com/puddly/serialpy or something in the future, since the zigpy libraries are written to not directly import pyserial in any way.

@bdraco

bdraco commented May 3, 2024

Copy link
Copy Markdown
Member Author

Thanks

@bdraco
bdraco merged commit ecdad19 into dev May 3, 2024
@bdraco
bdraco deleted the drop_pyserial_zha branch May 3, 2024 07:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants