Support entities autocomplete for local characters by lkostrowski · Pull Request #30399 · home-assistant/frontend

lkostrowski · 2026-03-28T12:49:14Z

Proposed change

PR adds custom normalization of searched queries (to select/combobox via Fuse.js). Current implementation properly works with some unicode characters, but fail for others

For example polish łazienika (bathroom) contains character ł. Fuse doesn't match it with non-diactric latin l character.

Effectively this ends up with poor UX with entity search. User must decide either to call entities incorrectly ("lazienka") or explicitly type "łazienka" which opts-out fuzzy search and is inconvenient (requires alt+l)

Screenshots

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

~~This PR fixes or closes issue: fixes #~~ not found existing
~~This PR is related to issue or discussion:~~ ditto
~~Link to documentation pull request:~~ n/a
~~Link to developer documentation pull request:~~ n/a
~~Link to backend pull request:~~ n/a

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

~~Documentation added/updated for www.home-assistant.io~~ n/a

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant

Hi @lkostrowski

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

piitaya

Thanks for the PR!

We had a similar issue before: we added custom diacritics logic (#21150), then removed it when Fuse.js shipped ignoreDiacritics natively (#24041).

The issue is that Fuse.js's ignoreDiacritics only uses NFD normalization, which doesn't handle characters like ł, ø, đ, or ß.

Your fix is the right approach. Could you also open a PR or issue on Fuse.js to fix their internal stripDiacritics? If they fix it upstream, we can remove this workaround again like we did in #24041.

You added normalizingGetFn to some standalone Fuse instances (quick-bar, automation-add-search,...) without adding ignoreDiacritics: true.
It works because you normalize search terms manually, but it's inconsistent with the other call sites. Can you add ignoreDiacritics: true to those instances too?

lkostrowski · 2026-03-31T06:10:21Z

Thanks for the review, I will look into that

PR to Fuse krisk/Fuse#816

lkostrowski · 2026-03-31T06:55:45Z

@piitaya if I understood correctly, I fixed the issue, I missed one spot where normalization was missing.

Maybe after fixing the bug, I will extract shared/common Fuse options to single instance for reused behavior

piitaya

Thank your for the update !

I added some suggested changes. Otherwise it's ok !

I agree, we can merge it after these changes and create another PR to share default fuse options.

piitaya · 2026-04-02T10:22:30Z

src/panels/config/integrations/ha-config-integrations-dashboard.ts

          keys: ["domain", "localized_domain_name", "title"],
          isCaseSensitive: false,
          minMatchCharLength: Math.min(filter.length, 2),
          threshold: 0.2,


We can also add ignoreDiacritics here too.

Probably need to add getFn: normalizingGetFn too

src/common/string/strip-diacritics.ts

src/panels/config/integrations/ha-config-integrations-dashboard.ts

piitaya · 2026-04-02T10:25:43Z

src/resources/fuseMultiTerm.ts

+  // Normalize non-decomposable diacritics in search terms to match getFn normalization
+  const normalizedSearch =
+    typeof search === "string" ? stripDiacritics(search) : search;
+


This function is not exported and only used in this file. Other callers already normalize terms before passing them in so the second strip is not useful.

I think it is needed, for example HaAutomationAddSearch component directly passes filter from UI and I can't find any normalization out there.

In general it's not too DRY, IMO we can solve it in two phases

Make actual fix, accept that the change is distributed (such implementation should not "leak" but we want small code increment)

Create a facade that will wrap Fuse, for example class FuzzySearch. Inside instantionate Fuse, allow to inject options, make a public "filter" method that will normalize inside it and delegate to Fuse. Then replace Fuse everywhere and block access to Fuse import in the codebase in other places than FuzzySearch. I can implement this

Applied other suggestions

home-assistant · 2026-04-02T10:29:02Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Characters like ł, ø, ß, đ, ħ, ŧ, ı survive NFD normalization unchanged. Add explicit replacement map to convert them to their ASCII equivalents (e.g. ł→l, ß→ss, ø→o). Based on the approach from home-assistant/frontend#30399. Closes #816 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-authored-by: Paul Bottein <paul.bottein@gmail.com>

Stale

MindFreeze · 2026-04-08T05:29:00Z

The fuse changes have been merged in #51457

lkostrowski · 2026-04-08T05:53:41Z

Great, looks like we ain't gonna need it anymore 👍

lkostrowski added 2 commits March 28, 2026 12:58

Custom characters stripping

c479fca

extra test

e517ba1

home-assistant bot added the cla-needed label Mar 28, 2026

home-assistant bot previously requested changes Mar 28, 2026

View reviewed changes

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Mar 28, 2026

lkostrowski and others added 2 commits March 28, 2026 13:51

any -> unkown

1082daa

Merge branch 'dev' into lkostrowski/combobox-diacritics

3ba65cf

lkostrowski marked this pull request as ready for review March 28, 2026 13:33

piitaya reviewed Mar 30, 2026

View reviewed changes

Merge branch 'dev' into lkostrowski/combobox-diacritics

f891c4e

lkostrowski mentioned this pull request Mar 31, 2026

fix: handle non-decomposable diacritics in stripDiacritics krisk/Fuse#816

Closed

lkostrowski and others added 2 commits March 31, 2026 08:53

Add missing normalization in dialog-new-dashboard

4e2d04e

Merge branch 'dev' into lkostrowski/combobox-diacritics

e5b2e28

lkostrowski requested a review from piitaya March 31, 2026 06:55

lkostrowski added 2 commits March 31, 2026 10:38

Merge branch 'dev' into lkostrowski/combobox-diacritics

8f00c3c

Merge branch 'dev' into lkostrowski/combobox-diacritics

c59f1d8

piitaya requested changes Apr 2, 2026

View reviewed changes

home-assistant bot marked this pull request as draft April 2, 2026 10:29

lkostrowski and others added 3 commits April 5, 2026 19:06

Apply suggestions from code review

86e233f

Co-authored-by: Paul Bottein <paul.bottein@gmail.com>

Merge branch 'dev' into lkostrowski/combobox-diacritics

146baf2

extra ignoreDiatricis flag

0c7cbae

lkostrowski marked this pull request as ready for review April 5, 2026 17:25

home-assistant bot requested a review from piitaya April 5, 2026 17:25

lkostrowski closed this Apr 8, 2026

Conversation

lkostrowski commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Screenshots

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

piitaya left a comment

Choose a reason for hiding this comment

Uh oh!

lkostrowski commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lkostrowski commented Mar 31, 2026

Uh oh!

piitaya left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piitaya Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

MindFreeze Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

piitaya Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

lkostrowski Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

lkostrowski Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

home-assistant bot commented Apr 2, 2026

Uh oh!

MindFreeze commented Apr 8, 2026

Uh oh!

lkostrowski commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lkostrowski commented Mar 28, 2026 •

edited

Loading

lkostrowski commented Mar 31, 2026 •

edited

Loading

piitaya left a comment •

edited

Loading