Skip to content

Home dashboard: enable/disable entities suggestion#51407

Open
pcan08 wants to merge 17 commits intohome-assistant:devfrom
pcan08:home-dashboard-enable-disable-entities-suggestion
Open

Home dashboard: enable/disable entities suggestion#51407
pcan08 wants to merge 17 commits intohome-assistant:devfrom
pcan08:home-dashboard-enable-disable-entities-suggestion

Conversation

@pcan08
Copy link
Copy Markdown
Contributor

@pcan08 pcan08 commented Apr 4, 2026

Proposed change

Add the capability to enable/disable suggested/predicted entities that are next to the favorites entities. Inspired by #51392 like #51401

The goal is to not show these entities if the user does not want to see them without taking control of the dashboard, so that if the dashboard have update the user can have them.

Screenshots

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to backend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

pcan08 and others added 2 commits April 3, 2026 17:38
Add a toggle in the edit overview dialog to show or hide the
"Welcome, [user]" greeting header on the home overview page,
following the same pattern as the existing summary enable/disable.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The welcome message is a greeting header, not a summary card, so it
now lives in a separate "Greeting" section above the "Summaries" section.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@wendevlin wendevlin requested a review from piitaya April 7, 2026 07:03
Copy link
Copy Markdown
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #51401 for the implementation, we should use ha-form component.
I added a needs UX because we want this feature but we should implement it the proper way. I know that @mbb365 already worked on a similar feature.

pcan08 and others added 2 commits April 7, 2026 18:38
Replace manual label/ha-switch markup with ha-form using a boolean
selector for better accessibility and consistency with the rest of
the codebase.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pcan08 and others added 2 commits April 8, 2026 04:50
@pcan08
Copy link
Copy Markdown
Contributor Author

pcan08 commented Apr 8, 2026

I propose to continue on this PR when #51401 is finished.

pcan08 and others added 5 commits April 8, 2026 16:09
Add a toggle in the Overview edit dialog to show or hide the
usage-predicted entities that fill remaining slots alongside favorites.
When disabled, the usage prediction fetch is skipped entirely.
The favorites entities helper text is updated to no longer reference
suggestions, which now have their own dedicated toggle and description.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the raw <p class="section-description"> with ha-input-helper-text
for the suggested entities toggle description, using the proper HA
component for helper text styling instead of custom CSS.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Aligns with the hidden_summaries naming convention used elsewhere.
Logic is inverted accordingly: undefined means shown (default),
true means hidden.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the manual label+switch+helper-text with ha-form using a boolean
selector.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pcan08
Copy link
Copy Markdown
Contributor Author

pcan08 commented Apr 9, 2026

How it looks with current state of #51401

image

@pcan08 pcan08 force-pushed the home-dashboard-enable-disable-entities-suggestion branch from 4bfb15a to f6d2bdb Compare April 9, 2026 09:17
@pcan08
Copy link
Copy Markdown
Contributor Author

pcan08 commented Apr 9, 2026

Now that #51401 is merged, I merged dev into this PR, but I have some concerns: shall we keep welcome message switch between favorites picker and suggested entities switch ? maybe move welcome message switch above favorites picker is more appropriate

@piitaya
Copy link
Copy Markdown
Member

piitaya commented Apr 9, 2026

I discussed that form with UX team yesterday.
Favorite entities and suggested must be grouped.

I guess we can group them using a expandable section (similar to background) :
CleanShot 2026-04-09 at 11 56 33

Also, we discussed the option names : It's more "Include" than "Show" for the suggested entities, right? WDYT?

Drop unused schema parameter from computeLabel/computeHelper callbacks
and shorten the label from "Show suggested entities" to "Suggested entities"
since the boolean checkbox already conveys the enabled/disabled intent.
@pcan08
Copy link
Copy Markdown
Contributor Author

pcan08 commented Apr 9, 2026

I'll give a try to expandable section, I am agree that we should group them.
For the wording, I can replace "show" by "include", but we could also remove it to be consistent with welcome message as I just did. what is your opinion about this ?

@piitaya
Copy link
Copy Markdown
Member

piitaya commented Apr 9, 2026

Label: Suggested entities
Description : Include additional entities...

That may work.

pcan08 and others added 2 commits April 9, 2026 12:36
Wrap ha-entities-picker and the suggested entities boolean in an outlined
ha-expansion-panel with a star-outline icon. Move the welcome message
toggle above the panel. Use "Favorite entities" as the panel header and
remove the redundant picker label.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pcan08
Copy link
Copy Markdown
Contributor Author

pcan08 commented Apr 9, 2026

Note that I use ha-expansion-panel instead of ha-form with expandable (this is how it is implemented for section background settings) as it is more simple and avoid refactor around entities picker which is not a ha-form.

Also note that there is no space between switch label and entities picker, this is due the helper text which is on 2 lines in ha-form. I guess this is a ha-form issue.

I think we should also group switches for summary cards in another PR.

Move inner padding from --expansion-panel-content-padding to a wrapper
div, matching the ha-form-expandable pattern, so no content is visible
when the panel is collapsed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants