Skip to content

Allow quick search for non-admins, while hiding inaccessible areas#51456

Merged
wendevlin merged 6 commits intodevfrom
fix-51284-non-admin-kbd-shortcuts
Apr 8, 2026
Merged

Allow quick search for non-admins, while hiding inaccessible areas#51456
wendevlin merged 6 commits intodevfrom
fix-51284-non-admin-kbd-shortcuts

Conversation

@timmo001
Copy link
Copy Markdown
Member

@timmo001 timmo001 commented Apr 7, 2026

Breaking change

Proposed change

From #51284

Allows keyboards shortcuts (quick search) but only shows what non-admins can typically see.

Shows navigation and entities, the rest are not returned.


This will probably generate another admin (access control) conversation, but all users can technically access these with knowhow (query parameters for more info, generated dashboards which don't need admin etc.). All my users are admins, I am using a test user to specifically test this in fact. This does bring down one barrier, and pages like devices could return in a read-only format later down the line.

TLDR: User is_admin is not access control, its a visual interim solution which will be refactored later, once a full architectural design is made

Screenshots

Hides admin only dashboards and pages not accessible by non-admins:

image image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

@timmo001 timmo001 changed the title Setup Allow quick search for non-admins, while hiding non-accessible areas Apr 7, 2026
@timmo001 timmo001 changed the title Allow quick search for non-admins, while hiding non-accessible areas Allow quick search for non-admins, while hiding inaccessible areas Apr 7, 2026
@timmo001 timmo001 marked this pull request as ready for review April 7, 2026 15:19
@wendevlin wendevlin self-assigned this Apr 8, 2026
@wendevlin wendevlin added this to the 2026.4 milestone Apr 8, 2026
@home-assistant home-assistant bot marked this pull request as draft April 8, 2026 07:39
@home-assistant
Copy link
Copy Markdown

home-assistant bot commented Apr 8, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@timmo001 timmo001 force-pushed the fix-51284-non-admin-kbd-shortcuts branch from e132631 to de33b87 Compare April 8, 2026 07:40
timmo001 and others added 4 commits April 8, 2026 08:41
Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
@timmo001 timmo001 requested a review from wendevlin April 8, 2026 07:44
@timmo001 timmo001 marked this pull request as ready for review April 8, 2026 07:44
Copy link
Copy Markdown
Member

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wendevlin wendevlin merged commit 20d53a2 into dev Apr 8, 2026
12 checks passed
@wendevlin wendevlin deleted the fix-51284-non-admin-kbd-shortcuts branch April 8, 2026 07:50
bramkragten pushed a commit that referenced this pull request Apr 10, 2026
…51456)

Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts do not work on a non-admin user

3 participants