Allow quick search for non-admins, while hiding inaccessible areas#51456
Merged
Allow quick search for non-admins, while hiding inaccessible areas#51456
Conversation
wendevlin
requested changes
Apr 8, 2026
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
e132631 to
de33b87
Compare
Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
bramkragten
pushed a commit
that referenced
this pull request
Apr 10, 2026
…51456) Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
From #51284
Allows keyboards shortcuts (quick search) but only shows what non-admins can typically see.
Shows navigation and entities, the rest are not returned.
This will probably generate another admin (access control) conversation, but all users can technically access these with knowhow (query parameters for more info, generated dashboards which don't need admin etc.). All my users are admins, I am using a test user to specifically test this in fact. This does bring down one barrier, and pages like devices could return in a read-only format later down the line.
TLDR: User
is_adminis not access control, its a visual interim solution which will be refactored later, once a full architectural design is madeScreenshots
Hides admin only dashboards and pages not accessible by non-admins:
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: