Render camera favorites as camera tiles - #53814
Open
balloob wants to merge 1 commit into
Open
Conversation
Favorites rendered every entity as a tile, so a camera showed a small round thumbnail instead of its picture. Give cameras the picture card the area sections already use. Replaces the tile config that the home overview, the common controls section and the security view each built inline, so favorites render the same way everywhere. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGaTMZkHP89siYzrA5zr2b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Favoriting a camera rendered it as a regular tile, so the camera showed up as a small round thumbnail next to its name instead of showing its picture. Cameras now get the same
picture-entitycard that the area sections already use for them.Applies to both dashboards that have favorites:
common-controlsfavorites section and the pinned-only section used when suggested entities are hidden.The three call sites each built the same tile config inline. They now share
computeFavoriteCardConfig, so favorites render the same way everywhere.Three notes for reviewers:
computeAreaTileCardConfigproduces (show_name: false, 6x2), so a favorited camera looks like a camera anywhere else on the dashboard. Happy to turn the name on for favorites if you would rather have the label there, since favorites have no area heading to give them context.common-controlsalso renders usage-prediction results, not just pinned favorites, so a camera arriving there through prediction gets the picture card too. That seemed right, since a camera is a poor tile either way.computeAreaTileCardConfigbecause favorites render different state string.Screenshots
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests:
Generated by Claude Code