Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Z-Wave firmware downloads by switching from GitHub Releases asset downloads (blocked by CORS and previously proxied) to fetching firmware binaries via the NabuCasa/silabs-firmware-builder releases branch manifests, including checksum verification.
Changes:
- Fetches a list of stable GitHub releases and searches for a ZWA-2
.gblentry viamanifest.jsonon thereleasesbranch. - Downloads firmware via
raw.githubusercontent.comand verifies size + checksum (SHA-256 or SHA3-256). - Adds
@noble/hashesdependency to support SHA3-256 verification.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/firmware-download.ts | Switches firmware download source to release-branch manifests and adds checksum verification logic. |
| package.json | Adds @noble/hashes dependency required for SHA3-256 verification. |
| package-lock.json | Locks the newly added @noble/hashes dependency. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #40
corsproxy.io is no longer free and due to lack of a good alternative, we now piggyback off this workaround for not being able to download from GitHub releases without running into CORS issues.