Skip to content

refactor: pass verify_ssl to remaining direct-Supervisor httpx callers #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patch76 merged 4 commits into from
May 7, 2026
Merged

refactor: pass verify_ssl to remaining direct-Supervisor httpx callers #1128

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2f5f3f
refactor: pass verify_ssl to remaining direct-Supervisor httpx callers
Patch76 May 5, 2026
732a98a
refactor: read verify_ssl from server.settings instead of server.client
Patch76 May 5, 2026
147ad5f
test: pin _restart_addon untested branches per Boy-Scout
Patch76 May 5, 2026
4b1e336
Merge upstream/master + address KP13 round-1 review (asks 1-7)
Patch76 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ha_mcp/settings_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,9 @@ async def _restart_addon(_: Request) -> JSONResponse:
# Short timeout — the supervisor kills our process during restart so
# the connection will drop. A connection drop is actually success.
try:
async with httpx.AsyncClient(timeout=5.0) as client:
async with httpx.AsyncClient(
timeout=5.0, verify=server.settings.verify_ssl
Comment thread
Patch76 marked this conversation as resolved.
) as client:
resp = await client.post(
"http://supervisor/addons/self/restart",
headers={"Authorization": f"Bearer {token}"},
Expand Down
5 changes: 4 additions & 1 deletion src/ha_mcp/tools/tools_bug_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

from ha_mcp import __version__

from ..config import get_global_settings
from ..utils.usage_logger import (
AVG_LOG_ENTRIES_PER_TOOL,
get_recent_logs,
Expand Down Expand Up @@ -181,7 +182,9 @@ async def _fetch_addon_logs() -> str:
return ""

try:
async with httpx.AsyncClient(timeout=10.0) as http_client:
async with httpx.AsyncClient(
timeout=10.0, verify=get_global_settings().verify_ssl
) as http_client:
resp = await http_client.get(
"http://supervisor/addons/self/logs",
headers={"Authorization": f"Bearer {token}"},
Expand Down
Loading