fix(calendar): switch ha_config_remove_calendar_event to WebSocket (closes #1413, #1416)

[kingpanther13]

What does this PR do?

ha_config_remove_calendar_event called the REST service calendar.delete_event — but HA's calendar component only registers calendar.create_event and calendar.get_events as REST services. delete_event and update_event live exclusively on the WebSocket API (calendar/event/delete, calendar/event/update) — see homeassistant/components/calendar/__init__.py:325-340.

Calling the non-existent REST service returned 400 Bad Request for every UID, regardless of whether the event existed. That is the same 400 #1416 was investigating against a freshly-created calendar.local_e2e_test event.

This PR:

1. Switches ha_config_remove_calendar_event to self._client.send_websocket_message({"type": "calendar/event/delete", ...}), checks result["success"], and raises ToolError(SERVICE_CALL_FAILED) with suggestions on WS failure.
2. Replaces the soft-assert test_delete_calendar_event (which used a hard-coded fake UID) with a deletable_event_uid fixture that creates a fresh event, retrieves its UID via ha_config_get_calendar_events, yields (entity_id, uid), and best-effort cleans up on teardown. The rewritten test hard-asserts both the positive path (first delete succeeds) and the negative path (re-delete of released UID fails with suggestions).

Closes #1413 — test hardening from #1413 is achievable now that the underlying delete works.
Closes #1416 — root cause is calendar.delete_event being WS-only, not a Local Calendar quirk or seeded-entity divergence.
Supersedes #1415.

Type of change

• 🐛 Bug fix
• ✨ New feature
• 📚 Documentation
• 🔧 Maintenance/refactor
• 🧪 Tests only
• 💥 Breaking change

Testing

• I have tested these changes with a LLM agent
• All automated tests pass (uv run pytest)
• Code follows style guidelines (uv run ruff check)

E2E suite needs Docker; running on a Termux dev host without it. CI validates end-to-end behavior.

Checklist

• I have updated documentation if needed

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where calendar event deletion was failing due to an incorrect attempt to use a REST service that does not exist in Home Assistant. By migrating the deletion logic to the appropriate WebSocket API, the tool now correctly interacts with the calendar component. Additionally, the test suite has been significantly improved to ensure reliable E2E validation by dynamically managing test event lifecycles.

Highlights

• API Migration: Switched the ha_config_remove_calendar_event tool from using the non-existent REST service calendar.delete_event to the correct WebSocket command calendar/event/delete.
• Error Handling: Implemented robust error handling for WebSocket failures, providing actionable suggestions to the user when a deletion fails.
• Test Hardening: Replaced fragile hard-coded tests with a new deletable_event_uid fixture that dynamically creates, retrieves, and cleans up test events, enabling reliable validation of both success and failure paths.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request migrates the ha_config_remove_calendar_event tool from a REST service call to a WebSocket command, aligning with Home Assistant's API requirements. It also enhances the E2E tests by introducing a fixture for creating and cleaning up temporary events, enabling more robust positive and negative testing. Feedback suggests refactoring the implementation to use the send_command method for better message management and delegating error handling to the centralized exception classification helper to maintain architectural consistency.

[github-actions]

🧪 Your changes are now in the dev channel!

Your PR has been merged to master and is available for testing in the dev channel.

Test your changes before the next stable release (biweekly Wednesday):
📖 Dev Channel Documentation

Quick start

# Run dev version
uvx ha-mcp-dev

# Check version
uvx ha-mcp-dev --version

Docker:

docker pull ghcr.io/homeassistant-ai/ha-mcp:dev
docker run --rm -i \
  -e HOMEASSISTANT_URL=http://your-ha:8123 \
  -e HOMEASSISTANT_TOKEN=your_token \
  ghcr.io/homeassistant-ai/ha-mcp:dev

---

Found an issue? Please open a new bug report and mention this PR for context.