fix(component): respect Home Assistant skip_pip - #2275
Conversation
|
@codex review — apply the review criteria in .gemini/styleguide.md in addition to AGENTS.md guidance |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe integration now respects Home Assistant’s ChangesExternally managed package mode
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to The PR correctly makes externally managed packages read-only under skip_pip, but package validation and server import are not bound to the same package generation, so stale or replaced files could run with administrator access in a compromised or inconsistent local environment. The change is mergeable with explicit owner awareness and follow-up to fail startup on a detected generation mismatch. Sequence Diagram(s)sequenceDiagram
participant HomeAssistant
participant EmbeddedServer
participant PackageMetadata
HomeAssistant->>EmbeddedServer: Provide skip_pip=True
EmbeddedServer->>PackageMetadata: Inspect installed ha-mcp distributions
PackageMetadata-->>EmbeddedServer: Return channel and version metadata
EmbeddedServer-->>HomeAssistant: Return compatible version or package error
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Description checkExplanation The description follows the required template, explains the behavior change, identifies it as a bug fix, records automated testing and style checks, links issue ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Implementation Summary
Validation:
Implementation notes:
|
|
@codex review — apply the review criteria in .gemini/styleguide.md in addition to AGENTS.md guidance |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90aef6b805
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What does this PR do?
Respects Home Assistant's skip_pip runtime flag for the in-process HA-MCP server package.
Closes #2272
Type of change
Testing
Focused mypy no longer reports a diagnostic in the new code. Its custom-component invocation still exits on 12 existing embedded_server baseline diagnostics, including the unavailable uvicorn stub.
Checklist
Summary by CodeRabbit