docs: add manage as approved verb for multi-modal tools - #919
docs: add manage as approved verb for multi-modal tools#919kingpanther13 wants to merge 3 commits into
manage as approved verb for multi-modal tools#919Conversation
Tools like ha_manage_addon (homeassistant-ai#913) and ha_manage_custom_tool (homeassistant-ai#854) combine several operations (get/set/list/call) behind one tool. The existing verb list had no good fit — "manage" captures this pattern. Updated in all four locations: - AGENTS.md naming convention + docstring verb list - .gemini/styleguide.md naming convention + docstring verb list Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project documentation to formally recognize 'manage' as an approved verb for multi-modal tools. This change supports the introduction of tools that combine multiple operations, such as proxying API calls and configuration management, ensuring consistent naming conventions across the codebase. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in AGENTS.md to include the 'manage' verb for multi-modal tools. The review comments correctly point out that this change is inconsistent with the repository's official style guide, which serves as the single source of truth for tool naming conventions and docstring verbs. The documentation should be updated in this PR to reflect these changes and maintain consistency.
|
I'd hold off on this until one of the referencing issues (#913 or #854) reaches implementation. The existing verbs each describe one operation. "Manage" covers several, which makes tool selection harder — especially at 92+ tools. Neither Naming conventions should follow tool design, not precede it. Once a tool is built, the right verb becomes obvious. If no existing verb fits, we can add |
|
@sergeykad that's a good point. I think that "manage" still fits best for those new tools, but I could probably reframe them as "call" as well. If I can't reframe them I can just have those PRs themselves add "manage" to the docs instead of doing this separate PR. Either way, I found that we have a deeper issue with the naming convention in agents and styleguide, see issue #943. I'll close this PR for now, I think a more broad PR addressing #943 would be a better first step and perhaps we can consider adding in a caveat that verbs can be added if there are truly no other options, and only if it makes sense. |
What does this PR do?
Adds
manageto the approved tool verb list (ha_<verb>_<noun>) for multi-modal tools that combine several operations behind one interface.Context: #913 proposes
ha_manage_addon(proxy API calls + set config) and #854 introducesha_manage_custom_tool(execute/save/list custom tools). Both combine operations that don't fit cleanly under any single existing verb (get,set,call, etc.). "Manage" captures this multi-modal pattern.Changes (4 locations):
AGENTS.md— naming convention list + docstring action verb list.gemini/styleguide.md— naming convention list + docstring action verb listType of change
Testing
uv run pytest)uv run ruff check)Checklist