Skip to content

docs: add manage as approved verb for multi-modal tools - #919

Closed
kingpanther13 wants to merge 3 commits into
homeassistant-ai:masterfrom
kingpanther13:docs/add-manage-verb
Closed

docs: add manage as approved verb for multi-modal tools#919
kingpanther13 wants to merge 3 commits into
homeassistant-ai:masterfrom
kingpanther13:docs/add-manage-verb

Conversation

@kingpanther13

Copy link
Copy Markdown
Member

What does this PR do?

Adds manage to the approved tool verb list (ha_<verb>_<noun>) for multi-modal tools that combine several operations behind one interface.

Context: #913 proposes ha_manage_addon (proxy API calls + set config) and #854 introduces ha_manage_custom_tool (execute/save/list custom tools). Both combine operations that don't fit cleanly under any single existing verb (get, set, call, etc.). "Manage" captures this multi-modal pattern.

Changes (4 locations):

  • AGENTS.md — naming convention list + docstring action verb list
  • .gemini/styleguide.md — naming convention list + docstring action verb list

Type of change

  • 🐛 Bug fix
  • ✨ New feature
  • 📚 Documentation
  • 🔧 Maintenance/refactor
  • 💥 Breaking change

Testing

  • I have tested these changes with a LLM agent
  • All automated tests pass (uv run pytest)
  • Code follows style guidelines (uv run ruff check)

Checklist

  • I have updated documentation if needed

Tools like ha_manage_addon (homeassistant-ai#913) and ha_manage_custom_tool (homeassistant-ai#854)
combine several operations (get/set/list/call) behind one tool. The
existing verb list had no good fit — "manage" captures this pattern.

Updated in all four locations:
- AGENTS.md naming convention + docstring verb list
- .gemini/styleguide.md naming convention + docstring verb list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project documentation to formally recognize 'manage' as an approved verb for multi-modal tools. This change supports the introduction of tools that combine multiple operations, such as proxying API calls and configuration management, ensuring consistent naming conventions across the codebase.

Highlights

  • Documentation Update: Added 'manage' to the list of approved action verbs for multi-modal tools in AGENTS.md.
  • Naming Convention: Updated the tool naming guidelines to include 'Manage' as a valid starting verb for tool descriptions.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/styleguide.md
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in AGENTS.md to include the 'manage' verb for multi-modal tools. The review comments correctly point out that this change is inconsistent with the repository's official style guide, which serves as the single source of truth for tool naming conventions and docstring verbs. The documentation should be updated in this PR to reflect these changes and maintain consistency.

Comment thread AGENTS.md
Comment thread AGENTS.md
@kingpanther13
kingpanther13 marked this pull request as ready for review April 8, 2026 12:10
@kingpanther13
kingpanther13 requested a review from a team April 8, 2026 12:10
@kingpanther13
kingpanther13 enabled auto-merge (squash) April 8, 2026 12:11
@sergeykad

Copy link
Copy Markdown
Collaborator

I'd hold off on this until one of the referencing issues (#913 or #854) reaches implementation.

The existing verbs each describe one operation. "Manage" covers several, which makes tool selection harder — especially at 92+ tools. Neither ha_manage_addon nor ha_manage_custom_tool exists yet. The actual implementation may split cleanly into existing verbs (call, set, get), making manage unnecessary.

Naming conventions should follow tool design, not precede it. Once a tool is built, the right verb becomes obvious. If no existing verb fits, we can add manage in the same PR that introduces the tool.

@kingpanther13

Copy link
Copy Markdown
Member Author

@sergeykad that's a good point. I think that "manage" still fits best for those new tools, but I could probably reframe them as "call" as well. If I can't reframe them I can just have those PRs themselves add "manage" to the docs instead of doing this separate PR.

Either way, I found that we have a deeper issue with the naming convention in agents and styleguide, see issue #943. I'll close this PR for now, I think a more broad PR addressing #943 would be a better first step and perhaps we can consider adding in a caveat that verbs can be added if there are truly no other options, and only if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants