Skip to content

Add validation for missing dbAdapter option #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bitshifter-9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add validation for missing dbAdapter option #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cli/parse-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ function parseOptions (options) {
config.inMemory = true
log.info('config', 'Storing all data in memory only')
} else {
if (!options.dbAdapter || typeof options.dbAdapter !== 'string') {
throw new Error('dbAdapter must be specified as a string when not using dbUrl or inMemory mode')
}
PouchDB.plugin(require(options.dbAdapter))
dbOptions.prefix = path.join(config.paths.data, 'data') + path.sep
log.info('config', 'Storing all data in ' + dbOptions.prefix + ' using ' + options.dbAdapter)
Expand Down
16 changes: 14 additions & 2 deletions test/unit/cli/parse-options-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ function getDefaultsMock () {
}

var logMock = {
info: function () {},
warn: function () {}
info: function () { },
warn: function () { }
}

var parseOptions = proxyquire('../../../cli/parse-options', {
Expand Down Expand Up @@ -315,5 +315,17 @@ test('parse options', function (group) {
t.end()
})

group.test('missing dbAdapter throws error', function (t) {
t.throws(parseOptions.bind(null, {
public: 'public',
data: 'data'
// dbAdapter is intentionally missing
// dbUrl is not provided
// inMemory is not set
}), 'throws error when dbAdapter is missing')

t.end()
})

group.end()
})