Increase server request timeout for long prompts#861
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Review NotesThis PR makes a clean refactoring that:
The changes are straightforward, well-documented, and follow good software engineering practices. Reviewed by claude-4.5-sonnet-20250929 · Input: 37 · Output: 2.4K · Cached: 221.4K |
There was a problem hiding this comment.
Code Review
This pull request extracts the server request timeout constant into a separate timeouts.ts file, increases its value from 5 minutes to 30 minutes to support long-running requests, and adds a corresponding unit test. Feedback was provided regarding a potential server crash in the timeout middleware due to duplicate timeout callbacks attempting to send headers twice.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| import { REQUEST_TIMEOUT_MS } from '../timeouts'; | ||
|
|
||
| describe('server request timeout', () => { | ||
| it('allows long-running model/proxy requests for 30 minutes', () => { |
There was a problem hiding this comment.
This test does not really test anything and should be removed.
| @@ -0,0 +1,2 @@ | |||
| // Keep long-running local/model/proxy requests alive long enough for large-context or multimodal prompts. | |||
| export const REQUEST_TIMEOUT_MS = 30 * 60 * 1000; // 30 minutes | |||
There was a problem hiding this comment.
No reason to have a separate file just for this constant. The constant should be eventually moved into src/main/constants.ts, but does not need to be as part of this change.
Summary
Fixes #858
Tests
Notes