Skip to content

Add es module shims to layout#37

Open
careilly wants to merge 1 commit into
hotwired:mainfrom
careilly:main
Open

Add es module shims to layout#37
careilly wants to merge 1 commit into
hotwired:mainfrom
careilly:main

Conversation

@careilly

Copy link
Copy Markdown

Add the es module shims to the layout.ejs.

Otherwise the demo fails mysteriously on older devices. (iOS before 16.4, for a start.)

Otherwise the demo fails mysteriously on older  devices. (iOS before
16.4, for a start.)
@Julien-R44

Copy link
Copy Markdown

I confirm that this is necessary. On my iOS 16.2 simulator I had a pretty error The page could not be loaded due to a configuration error. After adding the shims, it is working fine

@chelovek0v

Copy link
Copy Markdown

Safari up to version 16.4 doesn't support importmaps, hence no fancy "@hotwired/turbo" imports used in the demo page.

The SDK fails to find any window.Turbo objects on a page because modules won't load.

It was a bit confusing (typical) to not be able to test out the framework right from the start in "Quick Start" :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants