fix(#2219): trigger on_changed also for text alteration (!= deletion) - #2228
Open
litoj wants to merge 1 commit into
Open
fix(#2219): trigger on_changed also for text alteration (!= deletion)#2228litoj wants to merge 1 commit into
litoj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My original implementation discarded any change that altered the text in any other way than writing 1 char. This discarded pasted text as well as other plugins that may alter the text but are meant just to help with text input.
It can be argued that in most cases when a larger text change is made - whether by a plugin or by the user pasting in some text - the user likely doesn't actually want to see any completion. So this change may actually introduce back some minor annoyances in very rare cases, where even after the text alteration there still exist some completion items that could match it.
Ideally, this would be even more configurable, in essence just leaving the text change triggering to the user completely or at least have the condition be determined via a function in the config.
I can make that change here straight away (with this as the default), if you thing it is better in order to solve this issue once and for all.
Fixes happy663/dotfiles#301