Small bugfixes to MakeListDict in orgcheck.vim#76
Open
HenricoWitvliet wants to merge 1 commit intohsitz:masterfrom
Open
Small bugfixes to MakeListDict in orgcheck.vim#76HenricoWitvliet wants to merge 1 commit intohsitz:masterfrom
HenricoWitvliet wants to merge 1 commit intohsitz:masterfrom
Conversation
- "exec lineno + 1" didn't move the cursor, causing an infinite loop, changed to setpos. - if the function is called from a non-list line, this_indent did not exist yet, making "let last_indent = this_indent" give an error. - if there is no line with only whitespace after the starting position, then the loop does not finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed to setpos.
exist yet, making "let last_indent = this_indent" give an error.
then the loop does not finish.
Also changed tabs to spaces.