Skip to content

fix/snakemake-dependency-pytest#41

Open
guechhouth wants to merge 3 commits intohtcondor:mainfrom
guechhouth:fix/snakemake-pytests
Open

fix/snakemake-dependency-pytest#41
guechhouth wants to merge 3 commits intohtcondor:mainfrom
guechhouth:fix/snakemake-pytests

Conversation

@guechhouth
Copy link
Copy Markdown
Collaborator

Summary

Previously, the executor's tests were running against the old Snakemake version ^8.6.0. Now, they are tested against the latest version of Snakemake.

After updating the Snakemake's version, test_group_workflow was failing due to get getenv/PATH issue. Our executor plugin has getenv=False by default and the jobs did not have the right environment at EP. New Snakemake changes the scheduling internals, so the grouped jobs were more likely to run through the optimized ilp path, which resulted in a crash immediately since the PATH were missing. This could also explained why when I switched back to 8.6 version, the tests did not pass like they used to either.

Changes

  • changed Snakemake in pyproject.toml from 8.6.0 to >=9.6.2
  • updated the url to base classes to correct path
  • overrode get_envvars() to include PATH in test_workflow() so that the environment is transferred correctly and allow the mock jobs to run

fixes #31

@guechhouth guechhouth force-pushed the fix/snakemake-pytests branch from 9fd8396 to 3398e89 Compare March 20, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snakemake dependency

1 participant