Open
Conversation
9fd8396 to
3398e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the executor's tests were running against the old Snakemake version
^8.6.0. Now, they are tested against the latest version of Snakemake.After updating the Snakemake's version,
test_group_workflowwas failing due to get getenv/PATH issue. Our executor plugin hasgetenv=Falseby default and the jobs did not have the right environment at EP. New Snakemake changes the scheduling internals, so the grouped jobs were more likely to run through the optimizedilppath, which resulted in a crash immediately since thePATHwere missing. This could also explained why when I switched back to8.6version, the tests did not pass like they used to either.Changes
pyproject.tomlfrom8.6.0to>=9.6.2get_envvars()to includePATHintest_workflow()so that the environment is transferred correctly and allow the mock jobs to runfixes #31