Label logic driver source + kind in hovers#388
Open
evanwporter wants to merge 8 commits into
Open
Conversation
evanwporter
commented
Jun 10, 2026
Collaborator
|
This makes more sense to me re: terminology. I'll leave it to @AndrewNolte to opine on the implementation. |
AndrewNolte
reviewed
Jun 11, 2026
AndrewNolte
reviewed
Jun 11, 2026
AndrewNolte
reviewed
Jun 11, 2026
AndrewNolte
reviewed
Jun 11, 2026
Collaborator
|
Sorry did a big refactor here for hover logic- #339 |
Contributor
Author
|
Nice fix. I like how it’s split up. It looks cleaner now.
Shouldn’t be too hard too resolve conflicts though it’s tough to say since
I’m on mobile
…On Mon, Jun 15, 2026 at 12:59 PM Andrew Nolte ***@***.***> wrote:
*AndrewNolte* left a comment (hudson-trading/slang-server#388)
<#388 (comment)>
Sorry did a big refactor here for hover logic- #339
<#339>
—
Reply to this email directly, view it on GitHub
<#388?email_source=notifications&email_token=A3QHV6PVQQPAW7RDMLUYVQL5ABISVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZRGE4TCNBXGE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4711914714>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3QHV6OKB3IPKUTXY4UF7OT5ABISVAVCNFSNUABGKJSXA33TNF2G64TZHMYTANBSGE4DKMBYGQ5US43TOVSTWNBWGMZTMNJWGA4DLILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A3QHV6PO4VWKT6XSLPMXAET5ABISVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZRGE4TCNBXGE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A3QHV6I6MDDEWTBTHS4C4NT5ABISVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZRGE4TCNBXGE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
it works but the way that the |
logic driver source + kind in hovers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #351
Copied from MikePopoloski/slang#1861
Within SystemVerilog the
logickeyword is somewhat unique in that its meaning isn't wholly contained within the declaration ("meaning" isn't quite the right word here but hopefully you get my point :) ).Consider (FYI: I used chatgpt to generate the following examples):
1.
logicassigned by a continuous assignment2.
logicassigned as combinational logic3.
logicassigned as a latch4.
logicassigned as a register / flip-flopIn all 4 examples
qis avariable, however the exact way that q is set changes in each example.To this end this PR attemps to add an additional piece of info to the hovers that distinguishes between each of the different ways
qcan be set--ie: as a latch, net or register.Images: