[Neovim] Handle textDocument/inactiveRegions#402
Conversation
|
|
||
| local ns = vim.api.nvim_create_namespace("SlangServerInactiveRegions") | ||
|
|
||
| vim.api.nvim_set_hl(0, "SlangServerInactiveRegion", { |
There was a problem hiding this comment.
i thought about moving this to the highlight lua file, but I was having issues with the load order when I did
There was a problem hiding this comment.
highlights.lua is for sure where this should live, with the value ideally pulled from config.lua like the other highlight groups.
I'm not sure what load order problems there could be if you local highlights = require('slang-server._core.highlights') above. If you want to share specifics of the errors hit then we can debug.
There was a problem hiding this comment.
init.lua only gets executed when calling require('slang-server').setup({}), which may not ever happen, depending on the installation method (particularly after #399).
Prior to this, all plugin functionality has been lazy-loaded on the first :SlangServer invocation, but this is a new type of behaviour. The eager execution path when opening an SV buffer is ftplugin/systemverilog.lua, so the handler will have to be registered somewhere under there.
Also, while this init.lua is currently light, I'd prefer not to require('slang-server') under ftplugin/systemverilog.lua as it leaves a possible future footgun for more code to creep into the eager execution path.
I think the best approach is to move the whole handler attachment into inactive_regions.lua and require('slang-server._lsp.experimental.inactive_regions') in ftplugin/systemeverilog.lua.
| -- note: this config requires the slang_server to be explicitly named slang_server | ||
| vim.lsp.config("slang_server", { | ||
| capabilities = { | ||
| experimental = { | ||
| inactiveRegions = { | ||
| inactiveRegions = true, | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| handlers = { | ||
| ["textDocument/inactiveRegions"] = inactive_regions.handler, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
I think this races with the LSP initialisation. Once the slang-server LSP client has started, updating its capabilities retroactively won't have any effect, and we can't guarantee when this plugin will be loaded relative to the client.
Possible solutions:
- Document that the user needs to add this to their own LSP config if they want to use this feature.
- If the client is already running, update its capabilities and notify the server with
"workspace/didChangeConfiguration"(if that's supported, @AndrewNolte?)
The former is obviously less than ideal. Thoughts, @toddstrader?
There was a problem hiding this comment.
Incidentally the handler can be added after the client has started; it just has to be added to local client = vim.lsp.get_clients("slang_server") instead.
2 participants
This adds the
inactiveRegionscapability (introduced in #287) to the neovim plugin.We should still merge #352 since some people might not have the plugin, and some editors may not have support for this (ie: zed).
It works in basic cases, but there is an error when deleting many lines.
Feedback would be appreciated, since this is my first time doing substantial work w/ Neovim.
FYI: This PR is bootstrapped by AI.
Images: