SP ulysses native implementation#4084
Open
SunMarc wants to merge 1 commit into
Open
Conversation
SunMarc
commented
Jun 19, 2026
| wrapped = [] | ||
| for obj in result: | ||
| if isinstance(obj, torch.utils.data.DataLoader) and not isinstance(obj, SequenceShardingDataLoader): | ||
| obj = SequenceShardingDataLoader(obj, shard_group, attention=self._sp_attention) |
Member
Author
There was a problem hiding this comment.
_sp_attention is a bit ugly, this might change. lmk @winglian if you have a better design for this in order to deal with packed sequences.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a native SP implementation in accelerate so that it is compatible with FSDPv2 and deepspeed.
cc @qgallouedec for viz