Skip to content

Fixed Failing CI#3007

Merged
greenrazer merged 7 commits into
huggingface:mainfrom
greenrazer:fix-new-clippy-rules
Jun 26, 2025
Merged

Fixed Failing CI#3007
greenrazer merged 7 commits into
huggingface:mainfrom
greenrazer:fix-new-clippy-rules

Conversation

@greenrazer

@greenrazer greenrazer commented Jun 26, 2025

Copy link
Copy Markdown
Contributor
  • Fixed new version Clippy errors
  • Fixed new version Rust formatting errors
  • Fixed Python workflow by updating actions/cache to the newest version
  • Fixed Maturin workflow by creating unique names per OS
  • Fixed Rust-Mac 'ring' dependency issue where it wasn't compiling for ARM Mac, so now testing against Intel Mac

@greenrazer greenrazer force-pushed the fix-new-clippy-rules branch from 65876c5 to ffb6335 Compare June 26, 2025 22:30
@greenrazer greenrazer changed the title Fixed issues created by new clippy version Fixed Failing CI Jun 26, 2025
@greenrazer greenrazer merged commit 0cd4fc4 into huggingface:main Jun 26, 2025
15 of 20 checks passed
john-sharratt pushed a commit to john-sharratt/candle that referenced this pull request May 7, 2026
* fixed clippy and new rust fmt

* po3 clippy changes

* updated workflow for PYO3

* tell maturin that version will be determined dynamically

* changed names of maturin workflow to avoid naming conflicts when uploading wheels

* switch to macos-13 bc ring crypto dependency not working on arm based macs

* back to failing macOS-latest since we should be compiling against arm mac, and this error isn't our fault'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant