Load safetensors with i8#3042
Merged
Merged
Conversation
Contributor
|
Thanks! |
john-sharratt
pushed a commit
to john-sharratt/candle
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have a small ML-enabled app that uses candle with wasm under the hood. Downloading the model takes a long time so I quantized it to 8-bit integers. Candle doesn't have an I8
DTypeand the safetensors load doesn't support I8.This PR adds the ability to load a safetensors file with I8 by upcasting it to I64, similar to the existing I32 to I64 conversion.
Based on this PR for adding a
DType::I32, I skipped adding aDType::I8for now, but would consider that if requested.Thanks!