pick seed <= u32::MAX when using metal#3045
Merged
Merged
Conversation
greenrazer
suggested changes
Aug 5, 2025
greenrazer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution!
6e48425 to
5250b76
Compare
Contributor
Author
|
Addressed review feedback. I had to add |
5250b76 to
1dadffd
Compare
greenrazer
approved these changes
Aug 20, 2025
greenrazer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for implementing this! I mistakenly thought cfg_if was in the standard library. To avoid adding external dependencies, I’ll need to roll back these most recent changes before merging. Really appreciate your work here, my mistake for not checking the dependency requirements first.
Contributor
Author
|
No problem, thanks for maintaining the package. |
john-sharratt
pushed a commit
to john-sharratt/candle
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running the stable diffusion example with Metal results in an error with the seed (possibly) being out of range.
The user can manually set
--seedbut we can make this easier.Solution
Generate the seed up to
u32::MAXwhen metal is enabled.