Fix broken slice_scatter example in basics.rs#3062
Merged
Conversation
- Change tensor b from [1,2] row vector to [2,1] column vector - Fix assertion to match expected result after column replacement - Resolves shape mismatch error that prevented example from running
john-sharratt
pushed a commit
to john-sharratt/candle
that referenced
this pull request
May 7, 2026
Fix broken slice_scatter example in basics.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
basics.rsexample incandle-core/examplesfails to run due to a shape mismatch error:$ cargo run --example basics -p candle-core Error: shape mismatch in slice-scatter (self, src), lhs: [3, 2], rhs: [2, 1]because
Fix
Also updated the assertion to match the expected result after column replacement.