NdIter + cpu vec_add and vec_scalar_add#3579
Merged
Merged
Conversation
…lar vec impls. Remove const delegation flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-dimensional iterator. Similar to numpy nditer and pytorch TensorIterator.
Initially this will be used to optimize binary paths, specifically for CPU in this PR, but with some additions we can use it to improve gpu performance as well.
No measurable impact on f32 contiguous binary, as rust and llvm already optimizes the zip loop perfectly, but for broadcasting (including scalar broadcast) we get really good performance now. Additionally (especially on neon with this PR) we get a huge perf improvement on f16/bf16, with the biggest change being bf16 broadcast throughput being up 7000% 👀
Benchmark results: