Parameter cache for CUDA kernel launch#3598
Open
guoqingbao wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@EricLBuehler Do you have time to try this? I think you've supported cuda graph in mistral.rs recently? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Candle uses
htodto copy kernel launch parameters to the device, which makes CUDA graph capture inefficient because it captures tens of host-to-device operations in each forward pass. This PR addresses the kernel launch bottleneck by caching kernel parameters, delivering ~10% performance speedup across ALL models, as validated in vLLM.rs (xinfer): guoqingbao/xinfer#371.Usage:
Before CUDA graph capture, enable the parameter cache and run a warmup step. This caches the kernel launch parameters:
Then perform the actual CUDA graph capture:
Results from xinfer:
Note: This PR does not benefit
candle-examplesby default. It is intended for downstream projects that rely on Candle and support CUDA graphs.