Error instead of deadlocking when in-place op operands share storage#3614
Open
NahButch wants to merge 1 commit into
Open
Error instead of deadlocking when in-place op operands share storage#3614NahButch wants to merge 1 commit into
NahButch wants to merge 1 commit into
Conversation
inplace_op2/inplace_op3 take a write lock on self's storage and then a read lock on the other operands' storage. When the operands are views into the same tensor, both locks target the same non-reentrant RwLock and the call deadlocks. Detect shared storage with same_storage and return a clear error, the same contract slice_set already uses. Adds a regression test; on the previous code it hangs forever. Fixes huggingface#3227 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inplace_op2/inplace_op3take a write lock on self's storage and then a read lock on the other operands' storage. When the operands are views into the same tensor, both locks target the same non-reentrant RwLock and the call deadlocks.Detect shared storage with
same_storageand return a clear error — the same contractslice_setalready uses. Adds a regression test; on the previous code it hangs forever (verified via timeout).Fixes #3227
🤖 Generated with Claude Code